Page MenuHomeFreeBSD
Differential D48841

cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA
ClosedPublic
Actions

Authored by imp on Feb 4 2025, 6:38 PM.
Tags
None
Referenced Files
F164628997: D48841.id.diff
Sun, Aug 2, 4:35 PM
F164613111: D48841.diff
Sun, Aug 2, 11:38 AM
Unknown Object (File)
Thu, Jul 30, 9:04 PM
Unknown Object (File)
Thu, Jul 30, 6:22 PM
Unknown Object (File)
Mon, Jul 27, 9:20 PM
Unknown Object (File)
Sat, Jul 25, 8:41 PM
Unknown Object (File)
Sat, Jul 25, 1:06 AM
Unknown Object (File)
Tue, Jul 21, 12:15 AM
View All Files
Subscribers
None

Details

Reviewers
mav
ken
Group Reviewers
cam
Commits
rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA
Summary

This change mirrors what we do in da. Use only the VALID_MEDIA
flag. SAW_MEDIA was just used in one place. Transition to using
similar technique to what da uses for valid media.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Feb 4 2025, 6:38 PM
Herald added a reviewer: cam. · View Herald TranscriptFeb 4 2025, 6:38 PM
imp requested review of this revision.Feb 4 2025, 6:38 PM
imp added a parent revision: D48840: cam/cd: Simplify to remove invalid flag.
imp added a child revision: D48842: cam/da: Minor rework of sf bits for errors.
Harbormaster completed remote builds in B62251: Diff 150490.Feb 4 2025, 6:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2025, 9:43 PM
Closed by commit rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
7 lines

Diff 150727

View Options

sys/cam/scsi/scsi_cd.c

Loading...