Page MenuHomeFreeBSD
Differential D48844

cam/da: Remove redundant bp assignment
AbandonedPublic
Actions

Authored by imp on Tue, Feb 4, 6:40 PM.
Tags
None
Referenced Files
F109843211: D48844.id150493.diff
Mon, Feb 10, 6:20 AM
F109837676: D48844.diff
Mon, Feb 10, 4:24 AM
Unknown Object (File)
Wed, Feb 5, 5:59 AM
Unknown Object (File)
Wed, Feb 5, 12:56 AM
Subscribers
None

Details

Reviewers
mav
ken
Group Reviewers
cam
Summary

We assigned bp before we fell into this loop. Since nothing can change
the bp associated with a ccb after we've assigned it in the da driver,
there's no need for this assignment.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62254
Build 59138: arc lint + arc unit

Event Timeline

imp created this revision.Tue, Feb 4, 6:40 PM
Herald added a reviewer: cam. · View Herald TranscriptTue, Feb 4, 6:40 PM
imp requested review of this revision.Tue, Feb 4, 6:40 PM
imp added a parent revision: D48843: cam/da: Allow read-retry to be disabled.
Harbormaster completed remote builds in B62254: Diff 150493.Tue, Feb 4, 6:40 PM
imp abandoned this revision.Thu, Feb 6, 6:36 PM

When the selected delete method isn't supported, and we retry with others, we can make bp go NULL since we requeue the command so it's reprocessed in dastart again. different delete methods have different limitations on size, so we can't just transform it to something else or fail the I/O.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
1 line

Diff 150493

View Options

sys/cam/scsi/scsi_da.c

Loading...