Page MenuHomeFreeBSD
Differential D48841

cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA
ClosedPublic
Actions

Authored by imp on Feb 4 2025, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 25, 9:00 AM
Unknown Object (File)
Tue, Jun 23, 6:37 PM
Unknown Object (File)
Sun, Jun 21, 9:13 PM
Unknown Object (File)
Fri, Jun 19, 11:56 PM
Unknown Object (File)
Wed, Jun 17, 4:10 PM
Unknown Object (File)
Sat, Jun 6, 7:02 PM
Unknown Object (File)
Sat, Jun 6, 7:01 PM
Unknown Object (File)
May 31 2026, 4:08 PM
View All Files
Subscribers
None

Details

Reviewers
mav
ken
Group Reviewers
cam
Commits
rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA
Summary

This change mirrors what we do in da. Use only the VALID_MEDIA
flag. SAW_MEDIA was just used in one place. Transition to using
similar technique to what da uses for valid media.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62251
Build 59135: arc lint + arc unit

Event Timeline

imp created this revision.Feb 4 2025, 6:38 PM
Herald added a reviewer: cam. · View Herald TranscriptFeb 4 2025, 6:38 PM
imp requested review of this revision.Feb 4 2025, 6:38 PM
imp added a parent revision: D48840: cam/cd: Simplify to remove invalid flag.
imp added a child revision: D48842: cam/da: Minor rework of sf bits for errors.
Harbormaster completed remote builds in B62251: Diff 150490.Feb 4 2025, 6:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2025, 9:43 PM
Closed by commit rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
7 lines

Diff 150490

View Options

sys/cam/scsi/scsi_cd.c

Loading...