nanobsd: Add uname/gname to the spec
ClosedPublic
Actions

Authored by jlduran on Feb 1 2025, 4:23 AM.

Details

Reviewers

emaste
imp

Commits

rGeb544c63fc96: nanobsd: Add uname/gname to the spec

Summary

Also include the default NanoBSD uname/gname in the specification file.

By default, NANO_DEF_UNAME and NANO_DEF_GNAME map to root and wheel
respectively.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62192
Build 59076: arc lint + arc unit

Event Timeline

jlduran requested review of this revision.Feb 1 2025, 4:23 AM

jlduran created this revision.

Harbormaster completed remote builds in B62192: Diff 150324.Feb 1 2025, 4:24 AM

jlduran added a parent revision: D48780: nanobsd: Prefer nano_umount to umount.Feb 1 2025, 4:24 AM

jlduran added a child revision: D48782: nanobsd: Make tgt_dir2symlink() take a mode.

imp accepted this revision.Feb 1 2025, 4:44 AM

This revision is now accepted and ready to land.Feb 1 2025, 4:44 AM

I'm not a fan of the wrapping for things like this; IMO it's better to just let it exceed 80 cols, or build up a string to add to the metalog piece by piece, etc.

Address suggestions:

Do not wrap strings

This revision now requires review to proceed.Feb 1 2025, 5:28 PM

I'm agnostic on the wrapping... I tend to use a 120ish limit myself, though I know that drives people nuts. Others in the project regularly commit > 80 < 100 lines and have for ~decades. kib is the only one that's still objecting.

This revision is now accepted and ready to land.Feb 1 2025, 5:29 PM

emaste accepted this revision.Feb 4 2025, 2:24 PM

Closed by commit rGeb544c63fc96: nanobsd: Add uname/gname to the spec (authored by jlduran). · Explain WhySat, Jan 17, 6:13 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rGeb544c63fc96: nanobsd: Add uname/gname to the spec.