Page MenuHomeFreeBSD

make_dev.9: Fix mda_cr typo + polish
ClosedPublic

Authored by ziaee on Jan 19 2025, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 1:09 PM
Unknown Object (File)
Thu, Feb 20, 3:07 PM
Unknown Object (File)
Tue, Feb 11, 8:49 PM
Unknown Object (File)
Sun, Feb 9, 6:24 PM
Unknown Object (File)
Feb 2 2025, 12:29 AM
Unknown Object (File)
Feb 2 2025, 12:19 AM
Unknown Object (File)
Feb 1 2025, 4:15 PM
Unknown Object (File)
Feb 1 2025, 5:49 AM
Subscribers

Details

Summary

The make_dev_args_init structure example said mda_cred, however the
correct form is mda_cr according to the reporter and my git grep.

Outstanding questions for src:

  1. I cant find devfs_lookup(9) referenced on line 211 of the rendered

page. What should this say?

Outstanding questions for doc:

  1. This is still a typo, but an application typo, so does the date bump?

While here, fix trivial typos (spacing, colons before examples, trailing
delimiter) and spdx.

Reported by: Evgenii Ivanov on Community Discord
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61951
Build 58835: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Jan 19 2025, 6:31 PM
This revision is now accepted and ready to land.Jan 19 2025, 10:17 PM

Clean up document description and devfs_lookup.
The document description was broken on apropos due to macros,
and make devfs lowercase. The devfs_lookup was changed from
a non existent xref to a function.

This revision now requires review to proceed.Jan 20 2025, 1:04 AM
share/man/man9/make_dev.9
207–211
share/man/man9/make_dev.9
44
205
206–207
206–207
207–211

If cdev is an argument to the event handler it would be nice to use .Fa to mark it up.

A new document description and easier grammar was contributed by jhb!

This revision is now accepted and ready to land.Jan 24 2025, 12:15 PM

Sorry, seems I used my old account.

mhorne added inline comments.
share/man/man9/make_dev.9
174

Braces not needed?

This revision was automatically updated to reflect the committed changes.
ziaee marked 7 inline comments as done.