if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT
ClosedPublic
Actions

Authored by zlei on Thu, Jan 23, 3:48 PM.

Details

Reviewers

bryanv

Group Reviewers

network

Commits

rG67e952ebaaad: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT
rG7d2a5c78a714: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT
rG92632371b360: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT

Summary

This driver does not need to retrieve those tunable during early boot. Meanwhile SYSCTL_INT can provide rich meta info such as description. sysctl net.link.vxlan will also report current setting.

MFC after: 1 week

Test Plan

# kldload if_vxlan
# sysctl net.link.vxlan
net.link.vxlan.legacy_port: 0
net.link.vxlan.reuse_port: 0

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Thu, Jan 23, 3:48 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptThu, Jan 23, 3:48 PM

zlei requested review of this revision.Thu, Jan 23, 3:48 PM

zlei added a child revision: D48646: Virtualise if_vxlan.Thu, Jan 23, 7:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jan 27, 3:56 PM

Closed by commit rG92632371b360: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG92632371b360: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT.

zlei added a commit: rG7d2a5c78a714: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT.Mon, Feb 3, 12:26 PM

zlei added a commit: rG67e952ebaaad: if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INT.Mon, Feb 3, 12:28 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_vxlan.c

6 lines

Diff 149766

View Options

if_vxlan(4): Prefer SYSCTL_INT over TUNABLE_INTClosedPublicActions