Page MenuHomeFreeBSD
Differential D48583

arm64: add HCRX_EL2 register
ClosedPublic
Actions

Authored by harry.moulton_arm.com on Jan 21 2025, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 18, 3:16 AM
Unknown Object (File)
Sun, Mar 15, 5:40 AM
Unknown Object (File)
Fri, Mar 6, 4:07 PM
Unknown Object (File)
Thu, Mar 5, 5:33 PM
Unknown Object (File)
Thu, Mar 5, 5:33 PM
Unknown Object (File)
Tue, Feb 24, 9:10 PM
Unknown Object (File)
Tue, Feb 24, 7:01 PM
Unknown Object (File)
Tue, Feb 24, 3:45 AM
View All 83 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rG4d1acfb132a5: arm64: add HCRX_EL2 register
Summary

HCRX_EL2 is the Extended Hypervisor Configuration Register introduced
with FEAT_HCX in ARMv8.7. All fields in this register are used for
features in ARMv8.7 and above. Initially zero the register, incase
firmware has not properly configured it.

Sponsored By: Arm Ltd
Signed-off-by: Harry Moulton <harry.moulton@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61880
Build 58764: arc lint + arc unit

Event Timeline

harry.moulton_arm.com created this revision.Jan 21 2025, 5:47 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 21 2025, 5:47 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
harry.moulton_arm.com requested review of this revision.Jan 21 2025, 5:47 PM
Harbormaster completed remote builds in B61872: Diff 149676.Jan 21 2025, 5:47 PM
harry.moulton_arm.com added a child revision: D48584: arm64/vmm: save and restore HCRX_EL2 register.Jan 21 2025, 5:47 PM
andrew added inline comments.Jan 21 2025, 6:17 PM
sys/arm64/arm64/locore.S
378–390

Is there a reason to put this in a VHE only code path? It's also unlikely to need the isb as there is one before the eret that can be used as the context synchronization event.

sys/arm64/include/armreg.h
721–727 ↗(On Diff #149676)

This should be in hypervisor.h as it's an EL2 only register.

harry.moulton_arm.com updated this revision to Diff 149706.Jan 22 2025, 2:02 PM

Moved HCRX register definition to hypervisor.h, moved initial
configuration of hcrx_el2 to after .Ldone_vhe

Harbormaster completed remote builds in B61880: Diff 149706.Jan 22 2025, 2:02 PM
andrew added inline comments.Jan 22 2025, 2:38 PM
sys/arm64/arm64/locore.S
400

This will trash the cptr_el2 value. After msr spsr_el2, x5 will be safe as that's the last register set based on VHE vs non-VHE/

harry.moulton_arm.com updated this revision to Diff 149711.Jan 22 2025, 3:21 PM

Move configuration of hcrx_el2 to avoid trashing cptr_el2

Harbormaster completed remote builds in B61882: Diff 149711.Jan 22 2025, 3:21 PM
andrew accepted this revision.Jan 22 2025, 3:41 PM
This revision is now accepted and ready to land.Jan 22 2025, 3:41 PM
Closed by commit rG4d1acfb132a5: arm64: add HCRX_EL2 register (authored by harry.moulton_arm.com, committed by andrew). · Explain WhyJan 23 2025, 5:28 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG4d1acfb132a5: arm64: add HCRX_EL2 register.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
19 lines
include/
35 lines

Diff 149706

View Options

sys/arm64/arm64/locore.S

Loading...
View Options

sys/arm64/include/hypervisor.h

Loading...