Page MenuHomeFreeBSD
Differential D48394

sound: Simplify pcm/feeder_mixer.c
Needs ReviewPublic
Actions

Authored by christos on Thu, Jan 9, 2:37 PM.

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary
  • Get rid of macro magic.
  • Make feed_mixer_info handling similar to most feeders.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61684
Build 58568: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Jan 9, 2:37 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 9, 2:37 PM
christos requested review of this revision.Thu, Jan 9, 2:37 PM
Harbormaster completed remote builds in B61607: Diff 148992.Thu, Jan 9, 2:37 PM
christos added a parent revision: D47638: sound: Implement AFMT_FLOAT support.Thu, Jan 9, 2:37 PM
christos added inline comments.
sys/dev/sound/pcm/feeder_mixer.c
52

We don't need to care about this, since all these types are defined as int32_t.

christos added inline comments.Thu, Jan 9, 2:40 PM
sys/dev/sound/pcm/feeder_mixer.c
52

Actually if SND_PCM_64 is set, intpcm32_t is defined as int64_t.
@dev_submerge.ch I think we might need to clean up these types altogether.

christos added inline comments.Thu, Jan 9, 2:44 PM
sys/dev/sound/pcm/feeder_mixer.c
52

I think we can just use int32_t and int64_t in place of intpcm*_t directly, and in this particular case, a simple #ifdef SND_PCM_64 to choose the right type. I'm not sure about the benefit of these types, since they are mostly just aliases for int32_t.

dev_submerge.ch added inline comments.Thu, Jan 9, 4:34 PM
sys/dev/sound/pcm/feeder_mixer.c
52

Hm, I have to investigate and look at all the use cases first. Also it looks like we lose precision here when the volume is changed somewhere else in the chain. But that's probably a general issue with the current feeder design.

christos added inline comments.Thu, Jan 9, 4:42 PM
sys/dev/sound/pcm/feeder_mixer.c
52

Yeah, this patch, as well as the others, are just a step towards making this codebase easier to work with. I think there is quite a lot of room for improvements.

christos added a parent revision: D48421: sound: Turn PCM_CLAMP_* macros into a function.Fri, Jan 10, 6:39 PM
christos updated this revision to Diff 149086.Fri, Jan 10, 6:43 PM

Rebase on top of D48421.

Harbormaster completed remote builds in B61656: Diff 149086.Fri, Jan 10, 6:43 PM
christos updated this revision to Diff 149159.Sun, Jan 12, 9:54 PM

Update to reflect changes in D47932 (use of pcm_sample_read_24bit()).

Harbormaster completed remote builds in B61684: Diff 149159.Sun, Jan 12, 9:54 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
176 lines

Diff 149159

View Options

sys/dev/sound/pcm/feeder_mixer.c

Loading...