Page MenuHomeFreeBSD
Differential D5784

Bump bio_cmd and bio_*flags from 8 bits to 16.
ClosedPublic
Actions

Authored by imp on Mar 30 2016, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 3:12 AM
Unknown Object (File)
Mon, Dec 2, 2:31 PM
Unknown Object (File)
Nov 18 2024, 1:27 PM
Unknown Object (File)
Nov 16 2024, 10:04 AM
Unknown Object (File)
Oct 2 2024, 1:10 PM
Unknown Object (File)
Oct 2 2024, 12:03 AM
Unknown Object (File)
Sep 28 2024, 5:32 PM
Unknown Object (File)
Sep 28 2024, 3:15 PM
View All 68 Files
Subscribers
None

Details

Reviewers
kib
scottl
ken
mckusick
Commits
rS297955: Bump bio_cmd and bio_*flags from 8 bits to 16.
Summary

Ken Merry needs some additional commands for his SMR work
I need at least one additional command and some flags for my io backpressure work

So I'm bumping these from 8 bits to 16 to keep alignments sane, etc,

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3077
Build 3109: arc lint + arc unit

Event Timeline

imp updated this revision to Diff 14748.Mar 30 2016, 7:55 PM
imp retitled this revision from to Bump bio_cmd and bio_*flags from 8 bits to 16..
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp updated this object.Mar 30 2016, 7:57 PM
imp added reviewers: ken, scottl, kib, mckusick.
ken accepted this revision.Mar 30 2016, 8:17 PM
ken edited edge metadata.

Looks good to me!

This revision is now accepted and ready to land.Mar 30 2016, 8:17 PM
scottl accepted this revision.Mar 30 2016, 8:27 PM
scottl edited edge metadata.
imp updated this object.Mar 30 2016, 10:59 PM
imp edited edge metadata.
kib accepted this revision.Mar 31 2016, 5:30 AM
kib edited edge metadata.

Note that 32bit accesses are slightly faster than 16bit, on x86. I would go with uint if touching this.

imp added a comment.Apr 11 2016, 7:54 PM
In D5784#123709, @kib wrote:

Note that 32bit accesses are slightly faster than 16bit, on x86. I would go with uint if touching this.

I've thought about this for a few days now. I think I'm going to pass on the suggestion. I don't want to push the end of the cached bit of the bio too far out.
Plus I don't see the need to have them so big.

Closed by commit rS297955: Bump bio_cmd and bio_*flags from 8 bits to 16. (authored by imp). · Explain WhyApr 14 2016, 5:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
geom/
4 lines
4 lines
mirror/
2 lines
raid3/
2 lines
sys/
8 lines
4 lines

Diff 14748

View Options

sys/geom/geom_io.c

Loading...
View Options

sys/geom/geom_subr.c

Loading...
View Options

sys/geom/mirror/g_mirror.c

Loading...
View Options

sys/geom/raid3/g_raid3.c

Loading...
View Options

sys/sys/bio.h

Loading...
View Options

sys/sys/buf.h

Loading...