Page MenuHomeFreeBSD

Bump bio_cmd and bio_*flags from 8 bits to 16.
ClosedPublic

Authored by imp on Mar 30 2016, 7:55 PM.

Details

Summary

Ken Merry needs some additional commands for his SMR work
I need at least one additional command and some flags for my io backpressure work

So I'm bumping these from 8 bits to 16 to keep alignments sane, etc,

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp retitled this revision from to Bump bio_cmd and bio_*flags from 8 bits to 16..
imp updated this object.
imp edited the test plan for this revision. (Show Details)
ken edited edge metadata.

Looks good to me!

This revision is now accepted and ready to land.Mar 30 2016, 8:17 PM
scottl edited edge metadata.
imp edited edge metadata.
kib edited edge metadata.

Note that 32bit accesses are slightly faster than 16bit, on x86. I would go with uint if touching this.

In D5784#123709, @kib wrote:

Note that 32bit accesses are slightly faster than 16bit, on x86. I would go with uint if touching this.

I've thought about this for a few days now. I think I'm going to pass on the suggestion. I don't want to push the end of the cached bit of the bio too far out.
Plus I don't see the need to have them so big.

This revision was automatically updated to reflect the committed changes.