Page MenuHomeFreeBSD

git-arc: fix diff2reviewers() with multiple reviewers
ClosedPublic

Authored by glebius on Dec 3 2024, 8:15 PM.
Tags
None
Referenced Files
F151861371: D47889.id147424.diff
Sat, Apr 11, 4:25 AM
F151857324: D47889.id.diff
Sat, Apr 11, 3:43 AM
Unknown Object (File)
Tue, Apr 7, 8:26 AM
Unknown Object (File)
Tue, Apr 7, 3:07 AM
Unknown Object (File)
Mar 12 2026, 3:31 PM
Unknown Object (File)
Mar 11 2026, 11:35 PM
Unknown Object (File)
Mar 8 2026, 4:18 AM
Unknown Object (File)
Mar 7 2026, 8:59 PM
Subscribers

Details

Summary

The select command of jq provides us with a multiline output. Thus, the
${userids} is a newline separated list. The recent change 9e84289f2c7e
explicitly said that we aren't going to translate newline to comma when
constructing JSON for the next command. It also forces the ${userids} to
be printed as is, with shell's field splitting disabled. So we end up
with invalid JSON, that is missing commas.

Fix this by enabling shell's field splitting by printing ${userids}
outside of double quotes.

Fixes: 9e84289f2c7e6b632047a75b653fcd587287a8b9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60936
Build 57820: arc lint + arc unit