git-arc: Fix fetching of reviewers
AbandonedPublic
Actions

Authored by markj on Dec 4 2024, 1:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 7, 6:30 AM

	Unknown Object (File)
	Sat, Apr 4, 3:46 AM

	Unknown Object (File)
	Wed, Mar 25, 4:05 AM

	Unknown Object (File)
	Tue, Mar 24, 9:03 PM

	Unknown Object (File)
	Tue, Mar 24, 12:30 PM

	Unknown Object (File)
	Feb 27 2026, 11:38 PM

	Unknown Object (File)
	Feb 8 2026, 6:09 AM

	Unknown Object (File)
	Dec 21 2025, 10:52 PM

View All 44 Files

Subscribers

imp

Details

Reviewers

jlduran
des

Summary

Let the shell normalize whitespace (i.e., convert newlines to spaces).
Otherwise we end up generating invalid JSON.

Fixes: 9e84289f2c7e ("git-arc: Prefer echo over printf")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60940
Build 57824: arc lint + arc unit

Event Timeline

markj created this revision.Dec 4 2024, 1:18 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2024, 1:18 AM

markj requested review of this revision.Dec 4 2024, 1:18 AM

Harbormaster completed remote builds in B60940: Diff 147436.Dec 4 2024, 1:18 AM

Is this the same as D47889?

This revision is now accepted and ready to land.Dec 4 2024, 1:38 AM

In D47893#1092074, @jlduran wrote:

Is this the same as D47889?

Yep, Gleb beat me to it. :)

Revision Contents
Changeset List

Path

Size

tools/

git/

git-arc.sh

2 lines

Diff 147436

View Options

tools/tools/git/git-arc.sh

git-arc: Fix fetching of reviewersAbandonedPublicActions