Page MenuHomeFreeBSD

git-arc: fix diff2reviewers() with multiple reviewers
ClosedPublic

Authored by glebius on Dec 3 2024, 8:15 PM.
Tags
None
Referenced Files
F176182188: D47889.id147424.diff
Fri, Oct 16, 6:23 PM
F176178190: D47889.diff
Fri, Oct 16, 5:24 PM
F176130874: D47889.id.diff
Fri, Oct 16, 8:36 AM
F176114671: D47889.id147437.diff
Fri, Oct 16, 5:46 AM
Unknown Object (File)
Fri, Oct 16, 1:49 AM
Unknown Object (File)
Thu, Oct 15, 8:10 PM
Unknown Object (File)
Tue, Oct 13, 9:39 PM
Unknown Object (File)
Mon, Oct 12, 8:36 AM
Subscribers

Details

Summary

The select command of jq provides us with a multiline output. Thus, the
${userids} is a newline separated list. The recent change 9e84289f2c7e
explicitly said that we aren't going to translate newline to comma when
constructing JSON for the next command. It also forces the ${userids} to
be printed as is, with shell's field splitting disabled. So we end up
with invalid JSON, that is missing commas.

Fix this by enabling shell's field splitting by printing ${userids}
outside of double quotes.

Fixes: 9e84289f2c7e6b632047a75b653fcd587287a8b9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable