This change moves support for Synopsys Designware APB UART out of ns8250 into a separate driver, and adds support for activating clock and hwreset resources when the EXT_RESOURCES option is present.
Details
Details
- Reviewers
andrew adrian - Group Reviewers
ARM - Commits
- rS297496: Move support for Synopsys Designware APB UART out of ns8250 and into a
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/arm/conf/A20 | ||
|---|---|---|
| 75 | Shouldn't the dependancy on ns8250 be handled in sys/conf/files ? I'm really not sure if this kind of stuff is ok. | |
| sys/arm/conf/A20 | ||
|---|---|---|
| 75 | When you have two options that need to be set it would be: ... optional uart uart_foo | uart uart_bar | |
Comment Actions
- Make uart_snps depend on uart_ns8250
- Remove redundant clk_disable calls before clk_release
| sys/dev/uart/uart_dev_ns8250.c | ||
|---|---|---|
| 455–456 | This doesn't seems to be needed anymore, the busy-detect property was when ns8250 wasn't snps aware. | |
| sys/dev/uart/uart_dev_snps.c | ||
|---|---|---|
| 159 | Two problems --
| |
Comment Actions
- uart_dev_ns8250: Remove support for "busy-detect" property.
- uart_dev_snps: allow to attach to ofwbus as well as simplebus to match uart_bus_fdt behavior.
| sys/dev/uart/uart_dev_snps.c | ||
|---|---|---|
| 284 | This is not needed. Owfbus is subclass of simplebus for some time, so binding to simplebus also matches to ofwbus. | |
| sys/dev/uart/uart_dev_snps.c | ||
|---|---|---|
| 284 | Have you tested this? I've found both are needed if the device could be a child of either. | |
| sys/dev/uart/uart_dev_snps.c | ||
|---|---|---|
| 284 | Yes, sure. Tegra, for example, doesn't not have 'base' SoC simplebus at all, all devices are children of ofwbus. Binding to base class also matches to all its subclasses. | |