Page MenuHomeFreeBSD
Differential D5749

uart: Add support for snps,dw-apb-uart clock and hwreset resources
ClosedPublic
Actions

Authored by jmcneill on Mar 26 2016, 6:05 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 11, 6:16 AM
Unknown Object (File)
Sun, Dec 8, 1:20 AM
Unknown Object (File)
Nov 22 2024, 10:22 PM
Unknown Object (File)
Nov 13 2024, 1:19 PM
Unknown Object (File)
Nov 13 2024, 3:00 AM
Unknown Object (File)
Nov 9 2024, 5:27 AM
Unknown Object (File)
Oct 29 2024, 3:43 PM
Unknown Object (File)
Oct 27 2024, 3:32 AM
View All Files
Subscribers
andrew
imp
manu_bidouilliste.com
mmel

Details

Reviewers
andrew
adrian
Group Reviewers
ARM
Commits
rS297496: Move support for Synopsys Designware APB UART out of ns8250 and into a
Summary

This change moves support for Synopsys Designware APB UART out of ns8250 into a separate driver, and adds support for activating clock and hwreset resources when the EXT_RESOURCES option is present.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 14631.Mar 26 2016, 6:05 PM
jmcneill retitled this revision from to uart: Add support for snps,dw-apb-uart clock and hwreset resources.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added a reviewer: ARM.
jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptMar 26 2016, 6:05 PM
manu_bidouilliste.com added a subscriber: manu_bidouilliste.com.Mar 26 2016, 6:22 PM
manu_bidouilliste.com added inline comments.
sys/arm/conf/A20
75 ↗(On Diff #14631)

Shouldn't the dependancy on ns8250 be handled in sys/conf/files ?
Something like :
dev/uart/uart_dev_ns8250.c optional uart uart_ns8250 | uart_snps

I'm really not sure if this kind of stuff is ok.

andrew added inline comments.Mar 26 2016, 6:32 PM
sys/arm/conf/A20
75 ↗(On Diff #14631)

When you have two options that need to be set it would be: ... optional uart uart_foo | uart uart_bar

jmcneill updated this revision to Diff 14632.Mar 26 2016, 7:15 PM
  • Make uart_snps depend on uart_ns8250
  • Remove redundant clk_disable calls before clk_release
jmcneill marked 2 inline comments as done.Mar 26 2016, 7:25 PM
manu_bidouilliste.com added inline comments.Mar 26 2016, 7:48 PM
sys/dev/uart/uart_dev_ns8250.c
460 ↗(On Diff #14632)

This doesn't seems to be needed anymore, the busy-detect property was when ns8250 wasn't snps aware.

jmcneill updated this object.Mar 26 2016, 8:01 PM
jmcneill added a child revision: D5752: allwinner: Convert to extres clk/hwreset APIs.Mar 26 2016, 9:40 PM
andrew added inline comments.Mar 27 2016, 8:33 AM
sys/dev/uart/uart_dev_ns8250.c
460 ↗(On Diff #14632)

It was kept around to give people a chance to update their dtb. It can be removed now.

sys/dev/uart/uart_dev_snps.c
158 ↗(On Diff #14632)

There seems to be a lot happening in this probe function that should be moved to attach.

jmcneill added inline comments.Mar 27 2016, 11:04 AM
sys/dev/uart/uart_dev_snps.c
158 ↗(On Diff #14632)

Two problems --

  • uart_bus_probe needs to know the ref clock frequency
  • uart_bus_probe -> ns8250_bus_probe access registers, so clocks must be enabled
jmcneill updated this revision to Diff 14649.Mar 27 2016, 3:50 PM
  • uart_dev_ns8250: Remove support for "busy-detect" property.
  • uart_dev_snps: allow to attach to ofwbus as well as simplebus to match uart_bus_fdt behavior.
jmcneill marked 2 inline comments as done.Mar 27 2016, 3:50 PM
mmel added a subscriber: mmel.Mar 27 2016, 4:00 PM
mmel added inline comments.
sys/dev/uart/uart_dev_snps.c
284 ↗(On Diff #14649)

This is not needed. Owfbus is subclass of simplebus for some time, so binding to simplebus also matches to ofwbus.

andrew added inline comments.Mar 27 2016, 4:02 PM
sys/dev/uart/uart_dev_snps.c
284 ↗(On Diff #14649)

Have you tested this? I've found both are needed if the device could be a child of either.

mmel added inline comments.Mar 27 2016, 4:12 PM
sys/dev/uart/uart_dev_snps.c
284 ↗(On Diff #14649)

Yes, sure. Tegra, for example, doesn't not have 'base' SoC simplebus at all, all devices are children of ofwbus. Binding to base class also matches to all its subclasses.

jmcneill updated this revision to Diff 14651.Mar 27 2016, 4:19 PM

Remove binding to ofwbus

jmcneill marked 3 inline comments as done.Mar 27 2016, 4:19 PM
jmcneill mentioned this in D5752: allwinner: Convert to extres clk/hwreset APIs.Mar 27 2016, 4:34 PM
andrew accepted this revision.Mar 30 2016, 10:20 AM
andrew added a reviewer: andrew.
This revision is now accepted and ready to land.Mar 30 2016, 10:20 AM
adrian accepted this revision.Apr 1 2016, 7:46 PM
adrian added a reviewer: adrian.
Closed by commit rS297496: Move support for Synopsys Designware APB UART out of ns8250 and into a (authored by jmcneill). · Explain WhyApr 1 2016, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
conf/
2 lines
2 lines
2 lines
2 lines
mv/
1 line
conf/
3 lines
dev/
uart/
13 lines
283 lines

Diff 14821

View Options

head/sys/arm/conf/A10

Loading...
View Options

head/sys/arm/conf/A20

Loading...
View Options

head/sys/arm/conf/ARMADA38X

Loading...
View Options

head/sys/arm/conf/RK3188

Loading...
View Options

head/sys/arm/mv/files.mv

Loading...
View Options

head/sys/conf/files

Loading...
View Options

head/sys/dev/uart/uart_dev_ns8250.c

Loading...
View Options

head/sys/dev/uart/uart_dev_snps.c

Loading...