Page MenuHomeFreeBSD
Differential D47569

mv: Convert tests to ATF.
Needs ReviewPublic
Actions

Authored by des on Thu, Nov 14, 11:31 AM.
Tags
None
Referenced Files
F102636082: D47569.diff
Fri, Nov 15, 3:41 AM
F102634528: D47569.id146448.diff
Fri, Nov 15, 3:09 AM
F102634005: D47569.id146454.diff
Fri, Nov 15, 2:58 AM
F102633706: D47569.id146439.diff
Fri, Nov 15, 2:51 AM
F102626988: D47569.diff
Fri, Nov 15, 12:41 AM
Subscribers
asomers
imp
markj

Details

Reviewers
asomers
Group Reviewers
Klara
tests
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60555
Build 57439: arc lint + arc unit

Event Timeline

des created this revision.Thu, Nov 14, 11:31 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 14, 11:31 AM
Harbormaster completed remote builds in B60555: Diff 146439.Thu, Nov 14, 11:31 AM
des requested review of this revision.Thu, Nov 14, 11:31 AM
des added a parent revision: D47568: mv: More style nits..
markj added a subscriber: markj.Thu, Nov 14, 2:36 PM
markj added inline comments.
bin/mv/tests/mv_test.sh
8

Our usual shell style puts opening braces on their own lines, though admittedly a number of sh test files don't do this.

30

Should this be wrapped with atf_check?

41

Should this be wrapped with atf_check?

des added a reviewer: tests.Thu, Nov 14, 4:18 PM
des added inline comments.
bin/mv/tests/mv_test.sh
8

I think we mostly don't in tests... maybe tests can weigh in

30

it should, thank you

41

it should, thank you

des updated this revision to Diff 146448.Thu, Nov 14, 4:35 PM

review feedback

Harbormaster completed remote builds in B60558: Diff 146448.Thu, Nov 14, 4:35 PM
des marked 2 inline comments as done.Thu, Nov 14, 4:35 PM
asomers added a subscriber: asomers.Thu, Nov 14, 5:31 PM

Shouldn't you delete cvt.pl? That looks like a one-time script to me.

des added a comment.Thu, Nov 14, 6:13 PM
In D47569#1085032, @asomers wrote:

Shouldn't you delete cvt.pl? That looks like a one-time script to me.

I never intended to add it, sorry

des updated this revision to Diff 146454.Thu, Nov 14, 6:14 PM

rm cvt.pl

Harbormaster completed remote builds in B60560: Diff 146454.Thu, Nov 14, 6:14 PM
asomers accepted this revision.Thu, Nov 14, 6:17 PM

LGTM. If you're feeling ambitious you can add test cases for symlink destinations and the other command line options.

This revision is now accepted and ready to land.Thu, Nov 14, 6:17 PM
des updated this revision to Diff 146468.Thu, Nov 14, 7:43 PM

descriptive names

This revision now requires review to proceed.Thu, Nov 14, 7:43 PM
Harbormaster completed remote builds in B60571: Diff 146468.Thu, Nov 14, 7:43 PM
des added a child revision: D47582: mv: Add test cases for command-line options..Thu, Nov 14, 8:13 PM

Revision Contents
Changeset List

PathSize
3 lines
bin/
mv/
tests/
2 lines
391 lines

Diff 146439

View Options

ObsoleteFiles.inc

Loading...
View Options

bin/mv/tests/Makefile

Loading...
View Options

bin/mv/tests/legacy_test.sh

Loading...
View Options

bin/mv/tests/mv_test.sh

Loading...