net80211: migrate FC0_TYPE_MASK / FC0_SUBTYPE_MASK frame type checks to macros
ClosedPublic
Actions

Authored by adrian on Nov 9 2024, 9:48 PM.

Details

Reviewers

bz
emaste

Group Reviewers

wireless

Commits

rGc249cc3822dc: net80211: migrate FC0_TYPE_MASK / FC0_SUBTYPE_MASK frame type checks to macros

Summary

Add macros for the management and control frame type checks that I've come across in the drivers.
Delete some now old code (eg ath's ieee80211_is_action()) as there's now a macro for it.

Local testing:

not yet, I have a lot of wifi devices to find and test against

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60474
Build 57358: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 9 2024, 9:48 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptNov 9 2024, 9:48 PM

adrian requested review of this revision.Nov 9 2024, 9:48 PM

Harbormaster completed remote builds in B60467: Diff 146216.Nov 9 2024, 9:48 PM

update w/ url

Harbormaster completed remote builds in B60468: Diff 146218.Nov 9 2024, 9:49 PM

adrian added a parent revision: D36615: net80211: clean up / add more macros to check the frame types.Nov 9 2024, 9:49 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

If you want please address the comments but given none is a logic problem I'll leave it to you.

sys/dev/ath/if_ath_tx.c
1136	superfluous ()
sys/dev/ipw/if_ipw.c
1122	I think style in this file doesn't need the space after !
sys/dev/otus/if_otus.c
1689	Space after !
sys/dev/usb/wlan/if_urtw.c
1726–1727	Those two could be macros as well.

This revision is now accepted and ready to land.Nov 9 2024, 11:22 PM

updates suggested by bz@

This revision now requires review to proceed.Nov 10 2024, 4:08 AM

Harbormaster completed remote builds in B60474: Diff 146228.Nov 10 2024, 4:08 AM

updates, thanks!

adrian added a child revision: D47503: net80211: remove IEEE80211_FC0_QOSDATA.Nov 10 2024, 4:14 AM

emaste accepted this revision.Nov 10 2024, 2:53 PM

This revision is now accepted and ready to land.Nov 10 2024, 2:53 PM

bz accepted this revision.Nov 10 2024, 6:15 PM

landed

In D47500#1086528, @adrian wrote:

landed

for reference c249cc3822dc002288700ee206cf28c0c6031449

emaste added a commit: rGc249cc3822dc: net80211: migrate FC0_TYPE_MASK / FC0_SUBTYPE_MASK frame type checks to macros.Nov 18 2024, 1:27 PM

FYI if Phab doesn't add the commit automatically (either because of a typo or misformatted commit message or because Phab is just broken) you can add it later via Edit Related Objects > Edit Commits and then paste the commit hash.