Details

Reviewers

danfe
kevans
aokblast
bapt

Group Reviewers

USB

Commits

rG4c556a4e8d14: libusb: implement `libusb_get_parent`

Summary

Newer versions of drivers such as libwacom (graphics tablets) or libfprint (fingerprint scanners) call g_usb_device_get_parent. This in turn calls libusb_get_parent on platforms which implement it, and returns NULL on platforms that don't. This patch implements this function on FreeBSD.

Test Plan

Tried different combinations of different devices connected to different hubs and it all seems to work. Tried on the AMD Framework 13. Used an ad-hoc program to test this but I'd eventually like to add a tree view kind of thing to usbconfig like in lsusb.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60396
Build 57280: arc lint + arc unit

Event Timeline

obiwac created this revision.Oct 7 2024, 5:18 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 7 2024, 5:18 PM

obiwac requested review of this revision.Oct 7 2024, 5:18 PM

Harbormaster completed remote builds in B59820: Diff 144429.Oct 7 2024, 5:18 PM

Implementation wise, this looks fine to me. Can you update libusb.3 as well and document this, maybe right around libusb_get_device, please?

libusb.3: add libusb_get_parent

Harbormaster completed remote builds in B60396: Diff 146049.Nov 5 2024, 11:16 AM

obiwac updated this revision to Diff 146050.Nov 5 2024, 11:21 AM

libusb.3: add libusb_get_parent

Harbormaster completed remote builds in B60398: Diff 146052.Nov 5 2024, 11:24 AM

kevans added a reviewer: USB.Jan 9 2025, 12:21 PM

mohammad_fbsdphab_thelightbird.com added a subscriber: mohammad_fbsdphab_thelightbird.com.Jan 9 2025, 1:22 PM

mohammad_fbsdphab_thelightbird.com added inline comments.Jan 9 2025, 2:04 PM

lib/libusb/libusb.3
227	Boy Scout Rule - It seems many functions are all listed under "LIBRARY INITIALISATION / DEINITIALISATION" while they better be under their own section. I would say at least align them with libusb.h.

mohammad_fbsdphab_thelightbird.com added inline comments.Jan 9 2025, 2:10 PM

lib/libusb/libusb10.c
6	This one is just a question being curious, I see your name added here but not in the other header files. Is this intentional or a mistake ?

Add missing section header in libusb.3 manpage

Harbormaster completed remote builds in B61612: Diff 149003.Jan 9 2025, 5:18 PM

obiwac added inline comments.Jan 9 2025, 5:19 PM

lib/libusb/libusb.3
227	Good catch!
lib/libusb/libusb10.c
6	I never really know what amount of code changes warrants adding my name to the copyright header, and I assumed that just adding a prototype in a header or adding a small manpage entry didn't qualify :)

markmi_dsl-only.net added a subscriber: markmi_dsl-only.net.Jan 9 2025, 7:29 PM

markmi_dsl-only.net added inline comments.

lib/libusb/libusb10.h
129 ↗	(On Diff #149003)	monwarez on Discord wrote: "this seems to change the ABI of the struct, does running without relinking work ?" but no specific text was indicated for what "this" is to refer to. So: I assume that is for the above addition to the middle of the libusb_device struct. It would appear to change the Binary Interface involved for at least all the functions that have a parameter like (for example): libusb_device * dev Note: I've not analyzed anything signficant. I'm just trying to make the monwarez note part of the review.