Page MenuHomeFreeBSD

unix: Add support for atomically setting the socket mode
ClosedPublic

Authored by markj on Oct 31 2024, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 22, 2:16 PM
Unknown Object (File)
Sat, Feb 22, 1:41 PM
Unknown Object (File)
Sat, Feb 22, 1:32 PM
Unknown Object (File)
Feb 14 2025, 1:47 AM
Unknown Object (File)
Feb 8 2025, 10:11 AM
Unknown Object (File)
Feb 8 2025, 3:07 AM
Unknown Object (File)
Jan 12 2025, 5:29 AM
Unknown Object (File)
Dec 29 2024, 5:44 PM
Subscribers

Details

Summary

With this patch, it is possible to call fchmod() on a unix socket prior
to binding it to the filesystem namespace, so that the mode is set
atomically. Without this, one has to call chmod() after bind(), leaving
a window where threads can connect to the socket with the default mode.
After bind(), fchmod() reverts to failing with EINVAL.

I believe this is compatible with Linux.

I did not modify the behaviour of fstat(), i.e., it continues to return
the mode as set by soo_stat().

PR: 282393

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60318
Build 57202: arc lint + arc unit

Event Timeline

markj requested review of this revision.Oct 31 2024, 6:30 PM

sys/_types.h is sufficient.

Update man pages, add some tests.

markj added reviewers: glebius, kib.
This revision is now accepted and ready to land.Nov 1 2024, 11:37 AM