Page MenuHomeFreeBSD

unix: Add support for atomically setting the socket mode
ClosedPublic

Authored by markj on Oct 31 2024, 6:30 PM.
Tags
None
Referenced Files
F152020857: D47361.id145938.diff
Sun, Apr 12, 3:42 AM
F151988872: D47361.id145938.diff
Sat, Apr 11, 11:19 PM
Unknown Object (File)
Tue, Apr 7, 4:45 PM
Unknown Object (File)
Mon, Apr 6, 6:06 AM
Unknown Object (File)
Sun, Apr 5, 9:07 AM
Unknown Object (File)
Sun, Mar 29, 7:42 AM
Unknown Object (File)
Sun, Mar 29, 1:45 AM
Unknown Object (File)
Tue, Mar 24, 9:35 PM
Subscribers

Details

Summary

With this patch, it is possible to call fchmod() on a unix socket prior
to binding it to the filesystem namespace, so that the mode is set
atomically. Without this, one has to call chmod() after bind(), leaving
a window where threads can connect to the socket with the default mode.
After bind(), fchmod() reverts to failing with EINVAL.

I believe this is compatible with Linux.

I did not modify the behaviour of fstat(), i.e., it continues to return
the mode as set by soo_stat().

PR: 282393

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60318
Build 57202: arc lint + arc unit

Event Timeline

markj requested review of this revision.Oct 31 2024, 6:30 PM

sys/_types.h is sufficient.

Update man pages, add some tests.

markj added reviewers: glebius, kib.
This revision is now accepted and ready to land.Nov 1 2024, 11:37 AM