Page MenuHomeFreeBSD
Differential D5728

libc: stop exporting curbrk and minbrk in the private namespace
ClosedPublic
Actions

Authored by emaste on Mar 24 2016, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 9:27 PM
Unknown Object (File)
Nov 28 2024, 9:44 AM
Unknown Object (File)
Nov 24 2024, 7:20 PM
Unknown Object (File)
Nov 24 2024, 6:01 AM
Unknown Object (File)
Nov 24 2024, 6:01 AM
Unknown Object (File)
Nov 24 2024, 12:48 AM
Unknown Object (File)
Nov 23 2024, 1:15 PM
Unknown Object (File)
Nov 23 2024, 6:33 AM
View All Files
Subscribers
andrew
br

Details

Reviewers
kib
jilles
Commits
rS297238: libc: stop exporting curbrk and minbrk in the private namespace
Summary

They are not used anywhere else in the base system and are an internal implementation detail that does not need to be exposed.

If there's a concern we could leave them on existing archs and remove them from arm64 and riscv at least.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 14575.Mar 24 2016, 2:15 PM
emaste retitled this revision from to libc: stop exporting curbrk and minbrk in the private namespace.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, jilles.
emaste added subscribers: andrew, br.
kib edited edge metadata.Mar 24 2016, 2:22 PM

How did you checked that the symbols are not used ?

Did you verified the import list of all base libs and binaries ?

emaste added a comment.Mar 24 2016, 2:48 PM
In D5728#122338, @kib wrote:

How did you checked that the symbols are not used ?

Did you verified the import list of all base libs and binaries ?

I checked the libs and binaries on my amd64 desktop, and did a quick inspection of source changes since FreeBSD 7.

kib accepted this revision.Mar 24 2016, 3:15 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Mar 24 2016, 3:15 PM
Closed by commit rS297238: libc: stop exporting curbrk and minbrk in the private namespace (authored by emaste). · Explain WhyMar 24 2016, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
2 lines
amd64/
2 lines
arm/
2 lines
i386/
2 lines
mips/
2 lines
powerpc/
2 lines
powerpc64/
2 lines
riscv/
2 lines
sparc64/
2 lines

Diff 14575

View Options

lib/libc/aarch64/Symbol.map

Loading...
View Options

lib/libc/amd64/Symbol.map

Loading...
View Options

lib/libc/arm/Symbol.map

Loading...
View Options

lib/libc/i386/Symbol.map

Loading...
View Options

lib/libc/mips/Symbol.map

Loading...
View Options

lib/libc/powerpc/Symbol.map

Loading...
View Options

lib/libc/powerpc64/Symbol.map

Loading...
View Options

lib/libc/riscv/Symbol.map

Loading...
View Options

lib/libc/sparc64/Symbol.map

Loading...