Page MenuHomeFreeBSD

libc: stop exporting curbrk and minbrk in the private namespace
ClosedPublic

Authored by emaste on Mar 24 2016, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 9:44 AM
Unknown Object (File)
Sun, Nov 24, 7:20 PM
Unknown Object (File)
Sun, Nov 24, 6:01 AM
Unknown Object (File)
Sun, Nov 24, 6:01 AM
Unknown Object (File)
Sun, Nov 24, 12:48 AM
Unknown Object (File)
Sat, Nov 23, 1:15 PM
Unknown Object (File)
Nov 23 2024, 6:33 AM
Unknown Object (File)
Nov 22 2024, 2:35 PM
Subscribers

Details

Summary

They are not used anywhere else in the base system and are an internal implementation detail that does not need to be exposed.

If there's a concern we could leave them on existing archs and remove them from arm64 and riscv at least.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to libc: stop exporting curbrk and minbrk in the private namespace.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, jilles.
emaste added subscribers: andrew, br.

How did you checked that the symbols are not used ?

Did you verified the import list of all base libs and binaries ?

In D5728#122338, @kib wrote:

How did you checked that the symbols are not used ?

Did you verified the import list of all base libs and binaries ?

I checked the libs and binaries on my amd64 desktop, and did a quick inspection of source changes since FreeBSD 7.

kib edited edge metadata.
This revision is now accepted and ready to land.Mar 24 2016, 3:15 PM
This revision was automatically updated to reflect the committed changes.