if_enc(4): Use new KPI to create enc interface
ClosedPublic
Actions

Authored by zlei on Jun 27 2024, 4:18 PM.

Details

Reviewers

ae
glebius

Group Reviewers

network

Commits

rG03f7680517c8: if_enc(4): Use new KPI to create enc interface
rGeacad82f3ad0: if_enc(4): Use new KPI to create enc interface

Summary

This driver only allow exactly one instance to be created. Clone
creating additional interfaces will get error EEXIST which is somewhat
confusing.

Convert to new KPI so we can get less confusing error ENOSPC.

MFC after: 1 week

Test Plan

Before the change:

# ifconfig enc create
ifconfig: interface enc already exists
# ifconfig enc1 create
ifconfig: interface enc1 already exists

After the change:

ifconfig enc create
ifconfig: SIOCIFCREATE2 (enc): No space left on device
# ifconfig enc1 create
ifconfig: SIOCIFCREATE2 (enc1): No space left on device

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 27 2024, 4:18 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptJun 27 2024, 4:18 PM

zlei requested review of this revision.Jun 27 2024, 4:18 PM

zlei added a parent revision: D45757: if_clone: Allow maxunit to be zero.

Rebased to latest main.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2024, 1:39 PM

Closed by commit rGeacad82f3ad0: if_enc(4): Use new KPI to create enc interface (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGeacad82f3ad0: if_enc(4): Use new KPI to create enc interface.

zlei added a commit: rG03f7680517c8: if_enc(4): Use new KPI to create enc interface.Oct 20 2024, 1:43 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_enc.c

46 lines

Diff 144713

View Options

if_enc(4): Use new KPI to create enc interfaceClosedPublicActions