Differential D46903

MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes
ClosedPublic
Actions

Authored by olce on Oct 4 2024, 7:57 AM.

Tags

None

Referenced Files

	F161396502: D46903.id.diff
	Fri, Jul 3, 10:19 AM

	Unknown Object (File)
	Thu, Jul 2, 8:21 AM

	Unknown Object (File)
	Thu, Jul 2, 8:14 AM

	Unknown Object (File)
	Thu, Jun 18, 8:19 PM

	Unknown Object (File)
	May 12 2026, 3:07 PM

	Unknown Object (File)
	May 12 2026, 2:10 PM

	Unknown Object (File)
	May 11 2026, 9:52 PM

	Unknown Object (File)
	Apr 27 2026, 5:03 PM

View All 94 Files

Subscribers

Details

Reviewers

emaste
jamie

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rGfbac48f4b460: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes
rG62d3e81935c6: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes
rGdb33c6f3ae9d: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes

Summary

Do this only when the headers for these functionalities were included
prior to this one. Indeed, if they need to be included, style(9)
mandates they should have been so before this one.

Remove the common MAC sysctl declaration from
<security/mac/mac_internal.h>, as it is now redundant (all its includers
also include <security/mac/mac_policy.h>).

Remove local such declarations from all policies' files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59714
Build 56600: arc lint + arc unit

Event Timeline

olce created this revision.Oct 4 2024, 7:57 AM

Owners added a reviewer: Restricted Owners Package.Oct 4 2024, 7:57 AM

Herald added subscribers: dab, imp. · View Herald TranscriptOct 4 2024, 7:57 AM

olce requested review of this revision.Oct 4 2024, 7:57 AM

Harbormaster completed remote builds in B59714: Diff 144201.Oct 4 2024, 7:57 AM

olce added a subscriber: bapt.Oct 4 2024, 8:17 AM

olce added a parent revision: D46902: jail.h: New SYSCTL_JAIL_PARAM_DECL().Oct 4 2024, 8:29 AM

jamie accepted this revision.Oct 16 2024, 2:57 AM

This revision is now accepted and ready to land.Oct 16 2024, 2:57 AM

Closed by commit rGdb33c6f3ae9d: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes (authored by olce). · Explain WhyDec 16 2024, 2:45 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGdb33c6f3ae9d: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes.

olce added a commit: rG62d3e81935c6: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes.Jan 16 2025, 6:09 PM

olce added a commit: rGfbac48f4b460: MAC: mac_policy.h: Declare common MAC sysctl and jail parameters' nodes.Jan 17 2025, 12:28 PM

Revision Contents
Changeset List

Path

Size

sys/

security/

mac/

7 lines

15 lines

mac_biba/

2 lines

mac_bsdextended/

mac_bsdextended.c

2 lines

mac_grantbylabel/

mac_grantbylabel.c

1 line

mac_ifoff/

2 lines

mac_ipacl/

2 lines

mac_lomac/

2 lines

mac_mls/

2 lines

mac_ntpd/

2 lines

mac_partition/

mac_partition.c

2 lines

mac_pimd/

2 lines

mac_portacl/

2 lines

mac_priority/

2 lines

mac_seeotheruids/

mac_seeotheruids.c

2 lines

mac_stub/

2 lines

mac_test/

2 lines

mac_veriexec/

2 lines

Diff 144201

sys/security/mac/mac_internal.h

Loading...

sys/security/mac/mac_policy.h

Loading...

sys/security/mac_biba/mac_biba.c

Loading...

sys/security/mac_bsdextended/mac_bsdextended.c

Loading...

sys/security/mac_grantbylabel/mac_grantbylabel.c

Loading...

sys/security/mac_ifoff/mac_ifoff.c

Loading...

sys/security/mac_ipacl/mac_ipacl.c

Loading...

sys/security/mac_lomac/mac_lomac.c

Loading...

sys/security/mac_mls/mac_mls.c

Loading...

sys/security/mac_ntpd/mac_ntpd.c

Loading...

sys/security/mac_partition/mac_partition.c

Loading...

sys/security/mac_pimd/mac_pimd.c

Loading...

sys/security/mac_portacl/mac_portacl.c

Loading...

sys/security/mac_priority/mac_priority.c

Loading...

sys/security/mac_seeotheruids/mac_seeotheruids.c

Loading...

sys/security/mac_stub/mac_stub.c

Loading...

sys/security/mac_test/mac_test.c

Loading...

sys/security/mac_veriexec/mac_veriexec.c

Loading...