Page MenuHomeFreeBSD
Differential D46891

libkldelf: returns EOPNOTSUPP for unrecognizable relocations
Needs ReviewPublic
Actions

Authored by khng on Oct 3 2024, 8:10 PM.
Tags
None
Referenced Files
F169155366: D46891.id144175.diff
Mon, Aug 31, 3:04 PM
Unknown Object (File)
Sun, Aug 30, 9:31 AM
Unknown Object (File)
Sat, Aug 29, 10:38 PM
Unknown Object (File)
Thu, Aug 27, 7:49 PM
Unknown Object (File)
Thu, Aug 27, 5:13 PM
Unknown Object (File)
Tue, Aug 25, 1:34 PM
Unknown Object (File)
Tue, Aug 25, 7:56 AM
Unknown Object (File)
Tue, Aug 25, 6:42 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
jhb
andrew
Summary

Suggested by: markj

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59698
Build 56584: arc lint + arc unit

Event Timeline

khng created this revision.Oct 3 2024, 8:10 PM
Herald added a reviewer: andrew. · View Herald TranscriptOct 3 2024, 8:10 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a subscriber: imp. · View Herald Transcript
khng requested review of this revision.Oct 3 2024, 8:10 PM
Harbormaster completed remote builds in B59698: Diff 144175.Oct 3 2024, 8:10 PM
khng added a parent revision: D46719: libkldelf: add a private library for kernel/kld-related ELF parsing.Oct 3 2024, 8:12 PM
khng added a child revision: D46893: libkldelf: use warnx instead of printf.Oct 4 2024, 1:11 AM
khng edited the summary of this revision. (Show Details)
markj added inline comments.Oct 4 2024, 1:15 PM
lib/libkldelf/ef_amd64.c
112

They aren't NOPs, they're just unimplemented. Do we actually need them here? I'm not sure which relocation sections kldxref is processing.

khng added inline comments.Oct 4 2024, 9:59 PM
lib/libkldelf/ef_amd64.c
112

True. Meanwhile I just put them here for the purpose of not letting the existing tool failing due to some obviously in-use stuff like ifunc/irelative/jmpslot. All the other values are those our krtld doesn't recognize anyway so they should be errored out in this case. Implementing them would be good as well for better multi-klds symbols resolving.

khng updated this revision to Diff 144281.Oct 4 2024, 10:02 PM

Comments update.

Harbormaster completed remote builds in B59770: Diff 144281.Oct 4 2024, 10:02 PM
khng marked an inline comment as done.Oct 4 2024, 10:02 PM
markj added inline comments.Oct 6 2024, 2:51 PM
lib/libkldelf/ef_amd64.c
112

I think a better way to handle this is to add an abort() or so to these cases, then run "make universe -DMAKE_JUST_KERNELS" and see if anything fails.

Revision Contents
Changeset List

PathSize
lib/
libkldelf/
11 lines
8 lines
4 lines
6 lines
5 lines
12 lines

Diff 144175

View Options

lib/libkldelf/ef_aarch64.c

Loading...
View Options

lib/libkldelf/ef_amd64.c

Loading...
View Options

lib/libkldelf/ef_arm.c

Loading...
View Options

lib/libkldelf/ef_i386.c

Loading...
View Options

lib/libkldelf/ef_powerpc.c

Loading...
View Options

lib/libkldelf/ef_riscv.c

Loading...