pf: remove ip(6) header argument from pf_reassemble(6)()
ClosedPublic
Actions

Authored by kp on Sep 12 2024, 1:14 PM.

Tags

None

Referenced Files

	F131665178: D46652.diff
	Fri, Oct 10, 4:08 AM

	Unknown Object (File)
	Mon, Oct 6, 6:09 AM

	Unknown Object (File)
	Sat, Oct 4, 6:25 AM

	Unknown Object (File)
	Fri, Oct 3, 5:58 AM

	Unknown Object (File)
	Thu, Oct 2, 6:16 AM

	Unknown Object (File)
	Sat, Sep 13, 10:13 PM

	Unknown Object (File)
	Jul 20 2025, 6:12 AM

	Unknown Object (File)
	Jul 11 2025, 10:31 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)()

Summary

Instead of passing the ip header and mbuf to pf_reassemble(), lookup
the header address in the mbuf.
ok henning@

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, 074ee1f915
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 12 2024, 1:14 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 12 2024, 1:14 PM

kp requested review of this revision.Sep 12 2024, 1:14 PM

Harbormaster completed remote builds in B59455: Diff 143278.Sep 12 2024, 1:14 PM

Looks good to me. I read this code carefully :)

This revision is now accepted and ready to land.Sep 14 2024, 7:05 AM

Closed by commit rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)() (authored by kp). · Explain WhySep 27 2024, 10:17 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_norm.c

14 lines

Diff 143833

View Options

pf: remove ip(6) header argument from pf_reassemble(6)()ClosedPublicActions