Page MenuHomeFreeBSD
Differential D46814

arm64: Stop setting x0 for pcb_onfault handlers
ClosedPublic
Actions

Authored by andrew on Sep 27 2024, 3:49 PM.
Tags
None
Referenced Files
F153962292: D46814.id144940.diff
Sat, Apr 25, 3:17 AM
Unknown Object (File)
Sun, Apr 19, 1:55 AM
Unknown Object (File)
Sun, Apr 19, 12:44 AM
Unknown Object (File)
Sat, Apr 18, 6:43 PM
Unknown Object (File)
Sat, Apr 18, 12:17 PM
Unknown Object (File)
Sat, Apr 18, 1:23 AM
Unknown Object (File)
Thu, Apr 16, 2:04 PM
Unknown Object (File)
Sat, Apr 4, 10:36 PM
View All 91 Files
Subscribers
emaste
imp

Details

Reviewers
kib
markj
manu
Group Reviewers
arm64
Commits
rG8803e789393c: arm64: Stop setting x0 for pcb_onfault handlers
Summary

All handlers set x0 before returning, there is no need to also do so
in the data abort exception handler.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59625
Build 56512: arc lint + arc unit

Event Timeline

andrew created this revision.Sep 27 2024, 3:49 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 27 2024, 3:49 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B59625: Diff 143809.Sep 27 2024, 3:49 PM
andrew requested review of this revision.Sep 27 2024, 3:49 PM
andrew added a parent revision: D46813: arm64: Support pmap_fault with a locked pmap.
andrew added a child revision: D46815: arm64: Check TDP_NOFAULTING in a data abort.
markj accepted this revision.Sep 30 2024, 8:58 AM
markj added inline comments.
sys/arm64/arm64/trap.c
378

This is the Mach error too, so not correct.

This revision is now accepted and ready to land.Sep 30 2024, 8:58 AM
Closed by commit rG8803e789393c: arm64: Stop setting x0 for pcb_onfault handlers (authored by andrew). · Explain WhyOct 15 2024, 5:25 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG8803e789393c: arm64: Stop setting x0 for pcb_onfault handlers.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
1 line

Diff 143809

View Options

sys/arm64/arm64/trap.c

Loading...