pf: remove pointless CURVNET_SET
ClosedPublic
Actions

Authored by kp on Sep 12 2024, 11:57 AM.

Tags

None

Referenced Files

	F132238695: D46648.diff
	Wed, Oct 15, 2:19 AM

	Unknown Object (File)
	Sat, Oct 4, 2:14 AM

	Unknown Object (File)
	Mon, Sep 29, 9:10 PM

	Unknown Object (File)
	Sep 3 2025, 10:09 PM

	Unknown Object (File)
	Aug 15 2025, 12:41 AM

	Unknown Object (File)
	Aug 9 2025, 1:13 AM

	Unknown Object (File)
	Aug 5 2025, 1:41 PM

	Unknown Object (File)
	Jul 28 2025, 3:08 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

glebius
zlei

Group Reviewers

network
pfsense

Commits

rG6d51791d2832: pf: remove pointless CURVNET_SET

Summary

We're already in the correct vnet when the pfil hook is called. Remove the
pointless set/restore.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59451
Build 56338: arc lint + arc unit

Event Timeline

kp created this revision.Sep 12 2024, 11:57 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 12 2024, 11:57 AM

kp requested review of this revision.Sep 12 2024, 11:57 AM

Harbormaster completed remote builds in B59451: Diff 143273.Sep 12 2024, 11:57 AM

kp added a parent revision: D46647: pf: dedupe layer 4 protocol code in pf_setup_pdesc().Sep 12 2024, 11:57 AM

kp added a child revision: D46649: pf: merge pf_test() and pf_test6().

glebius accepted this revision as: glebius.Sep 13 2024, 10:15 PM

This revision is now accepted and ready to land.Sep 13 2024, 10:15 PM

Looks good to me.

Closed by commit rG6d51791d2832: pf: remove pointless CURVNET_SET (authored by kp). · Explain WhySep 25 2024, 12:35 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6d51791d2832: pf: remove pointless CURVNET_SET.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

16 lines

Diff 143273

View Options

pf: remove pointless CURVNET_SETClosedPublicActions