Page MenuHomeFreeBSD
Differential D46446

vmm: Remove an unneeded lookup in devmem_create_cdev()
ClosedPublic
Actions

Authored by markj on Aug 27 2024, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 5:49 AM
Unknown Object (File)
Mon, Mar 3, 4:51 AM
Unknown Object (File)
Mon, Mar 3, 3:26 AM
Unknown Object (File)
Thu, Feb 20, 8:54 PM
Unknown Object (File)
Thu, Feb 20, 8:15 PM
Unknown Object (File)
Tue, Feb 18, 2:47 AM
Unknown Object (File)
Feb 1 2025, 1:02 AM
Unknown Object (File)
Jan 31 2025, 1:23 AM
View All 38 Files
Subscribers
imp

Details

Reviewers
corvink
jhb
Group Reviewers
bhyve
Commits
rGf4002135a2be: vmm: Remove an unneeded lookup in devmem_create_cdev()
Summary

The sole caller of this function already holds a pointer to the VM's
softc, so rather than passing the VM name and looking it up again, just
pass the softc pointer directly. This function is only called from an
ioctl context, so the softc structure will remain live.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
vmm/
13 lines

Diff 142572

View Options

sys/dev/vmm/vmm_dev.c

Show All 38 Lines
.Dt NVMECONTROL 8 .Dt NVMECONTROL 8
.Os .Os
.Sh NAME .Sh NAME
.Nm nvmecontrol .Nm nvmecontrol
.Nd NVM Express control utility .Nd NVM Express control utility
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Ic devlist .Ic devlist
.Op Fl h
.Nm .Nm
.Ic identify .Ic identify
.Op Fl v .Op Fl v
.Op Fl x .Op Fl x
.Op Fl n Ar nsid .Op Fl n Ar nsid
.Aq Ar device-id | Ar namespace-id .Aq Ar device-id | Ar namespace-id
.Nm .Nm
.Ic perftest .Ic perftest
▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines
.Aq Ar device-id .Aq Ar device-id
.Nm .Nm
.Ic io-passthru .Ic io-passthru
.Op args .Op args
.Aq Ar namespace-id .Aq Ar namespace-id
.Sh DESCRIPTION .Sh DESCRIPTION
NVM Express (NVMe) is a storage protocol standard, for SSDs and other NVM Express (NVMe) is a storage protocol standard, for SSDs and other
high-speed storage devices over PCI Express. high-speed storage devices over PCI Express.
.Ss devlist
List all NVMe controllers and namespaces along with their device nodes.
With the
.Fl h
argument, use unit suffixes: Byte, Kibibyte, Mebibyte, Gibibyte, Tebibyte
and Pebibyte (based on powers of 1024) when showing the disk space.
By default, uses Mebibyte.
pauamma_gundo.comUnsubmitted
Not Done
Inline Actions
and Pebibyte (based on powers of 1024) when showing the disk space.
- By default, shows in Mebityte.
+ By default, shows in Mebibyte.
.Ss identify

Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of taste. The typo itself is the important thing.

pauamma_gundo.com: Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of…
.Ss identify .Ss identify
The identify commands reports information from the drive's The identify commands reports information from the drive's
.Dv IDENTIFY_CONTROLLER .Dv IDENTIFY_CONTROLLER
if a if a
.Ar device-id .Ar device-id
is specified. is specified.
It reports It reports
.Dv IDENTIFY_NAMESPACE .Dv IDENTIFY_NAMESPACE
▲ Show 20 Lines • Show All 530 Lines • Show Last 20 Lines