Page MenuHomeFreeBSD
Differential D46004

libcxxrt: Add a stub implementation of __cxa_call_terminate
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.
Tags
None
Referenced Files
F114804009: D46004.diff
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Sat, Apr 12, 1:56 AM
Unknown Object (File)
Thu, Mar 27, 4:38 PM
Unknown Object (File)
Mar 11 2025, 1:05 PM
Unknown Object (File)
Mar 4 2025, 11:47 PM
Unknown Object (File)
Feb 10 2025, 6:33 PM
Unknown Object (File)
Feb 3 2025, 1:39 PM
Unknown Object (File)
Jan 24 2025, 9:10 PM
View All 48 Files
Subscribers
None

Details

Reviewers
imp
emaste
rlibby
andrew
Commits
rG6b5a9d287d03: libcxxrt: Add a stub implementation of __cxa_call_terminate
rGa1269171d71f: libcxxrt: Add a stub implementation of __cxa_call_terminate
rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate
Summary

This function is called by GCC 14 if a destructor invoked during
exception unwinding throws an exception.

Obtained from: libcxxrt commit 391a3dcc1054e18c2f0dff4e14d6d79ac95399d7

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jul 17 2024, 7:16 PM
Herald added a reviewer: andrew. · View Herald TranscriptJul 17 2024, 7:16 PM
jhb requested review of this revision.Jul 17 2024, 7:16 PM
jhb added a parent revision: D46003: Merge commit cb7a03b41fff from llvm git (by Nikolas Klauser):.
Harbormaster completed remote builds in B58686: Diff 141054.Jul 17 2024, 7:16 PM
jhb added a child revision: D46005: libcasper: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM
jhb added a comment.Jul 17 2024, 7:25 PM

I am not at all confident that this implementation is correct, and I've opened an upstream issue at https://github.com/libcxxrt/libcxxrt/issues/35

jhb updated this revision to Diff 141866.Aug 6 2024, 8:28 PM

Fix whitespace

Harbormaster completed remote builds in B58958: Diff 141866.Aug 6 2024, 8:28 PM
jhb edited the summary of this revision. (Show Details)Aug 6 2024, 8:28 PM

This has now been merged upstream to libcxxrt at https://github.com/libcxxrt/libcxxrt/pull/36. This is the last change needed to permit building amd64 with GCC 14.

jhb added a comment.Aug 20 2024, 8:47 PM

Ping

emaste accepted this revision.Aug 20 2024, 8:49 PM
This revision is now accepted and ready to land.Aug 20 2024, 8:49 PM
Closed by commit rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate (authored by jhb). · Explain WhyAug 21 2024, 5:38 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate.
emaste added a commit: rGa1269171d71f: libcxxrt: Add a stub implementation of __cxa_call_terminate.Oct 29 2024, 9:04 PM
jhb added a commit: rG6b5a9d287d03: libcxxrt: Add a stub implementation of __cxa_call_terminate.Nov 30 2024, 8:14 PM

Revision Contents
Changeset List

PathSize
contrib/
libcxxrt/
13 lines
lib/
libcxxrt/
4 lines
4 lines

Diff 142322

View Options

contrib/libcxxrt/exception.cc

# $FreeBSD$ # $FreeBSD$
PORTNAME= revive PORTNAME= revive
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.0.2 DISTVERSION= 1.0.2
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= vulcan@wired.sh MAINTAINER= lcook@FreeBSD.org
COMMENT= Extensible static code analysis framework for Go COMMENT= Extensible static code analysis framework for Go
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
USES= go:modules USES= go:modules
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= mgechev GH_ACCOUNT= mgechev
Show All 32 Lines
View Options

lib/libcxxrt/Version.map

# $FreeBSD$ # $FreeBSD$
PORTNAME= revive PORTNAME= revive
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.0.2 DISTVERSION= 1.0.2
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= vulcan@wired.sh MAINTAINER= lcook@FreeBSD.org
COMMENT= Extensible static code analysis framework for Go COMMENT= Extensible static code analysis framework for Go
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
USES= go:modules USES= go:modules
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= mgechev GH_ACCOUNT= mgechev
Show All 32 Lines
View Options

lib/libcxxrt/Version.map.arm

# $FreeBSD$ # $FreeBSD$
PORTNAME= revive PORTNAME= revive
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.0.2 DISTVERSION= 1.0.2
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= vulcan@wired.sh MAINTAINER= lcook@FreeBSD.org
COMMENT= Extensible static code analysis framework for Go COMMENT= Extensible static code analysis framework for Go
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
USES= go:modules USES= go:modules
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= mgechev GH_ACCOUNT= mgechev
Show All 32 Lines