Page MenuHomeFreeBSD

elftoolchain: Consistently use item count as the first argument to calloc
ClosedPublic

Authored by jhb on Jul 17 2024, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 4:53 PM
Unknown Object (File)
Thu, Nov 21, 1:44 PM
Unknown Object (File)
Wed, Nov 20, 2:51 PM
Unknown Object (File)
Mon, Nov 18, 3:20 PM
Unknown Object (File)
Nov 9 2024, 12:07 PM
Unknown Object (File)
Nov 9 2024, 12:07 PM
Unknown Object (File)
Nov 9 2024, 12:07 PM
Unknown Object (File)
Nov 6 2024, 9:32 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: jkoshy.

Will also ping @jkoshy

This revision is now accepted and ready to land.Jul 17 2024, 7:18 PM

Note that this was the only calloc instance in all of elftc that GCC warned about. All the others (even in this file) were already consistent with the number being first.

Hmm, I've been avoiding addressing warnings in contrib...

It's fine in elftoolchain - we are the primary consumer and either jkoshy or I can make the change upstream.