Page MenuHomeFreeBSD
Differential D46007

elftoolchain: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 12:07 PM
Unknown Object (File)
Sat, Nov 9, 12:07 PM
Unknown Object (File)
Sat, Nov 9, 12:07 PM
Unknown Object (File)
Wed, Nov 6, 9:32 PM
Unknown Object (File)
Wed, Nov 6, 7:39 PM
Unknown Object (File)
Wed, Nov 6, 6:35 AM
Unknown Object (File)
Tue, Oct 22, 9:03 AM
Unknown Object (File)
Oct 2 2024, 6:23 AM
View All 26 Files
Subscribers
jkoshy
jkoshy_users.sourceforge.net

Details

Reviewers
imp
emaste
rlibby
Commits
rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc
Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM
jhb created this revision.
jhb added a parent revision: D46006: libgeom: Consistently use item count as the first argument to calloc.
Harbormaster completed remote builds in B58689: Diff 141057.Jul 17 2024, 7:16 PM
jhb added a child revision: D46008: lib80211: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM
emaste accepted this revision.Jul 17 2024, 7:18 PM
emaste added a subscriber: jkoshy.

Will also ping @jkoshy

This revision is now accepted and ready to land.Jul 17 2024, 7:18 PM
jhb added a comment.Jul 17 2024, 7:26 PM

Note that this was the only calloc instance in all of elftc that GCC warned about. All the others (even in this file) were already consistent with the number being first.

rlibby accepted this revision.Jul 17 2024, 8:28 PM

Hmm, I've been avoiding addressing warnings in contrib...

emaste added a comment.Jul 17 2024, 8:44 PM

It's fine in elftoolchain - we are the primary consumer and either jkoshy or I can make the change upstream.

Closed by commit rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc.
jkoshy_users.sourceforge.net added a subscriber: jkoshy_users.sourceforge.net.Jul 20 2024, 7:20 AM

Folded in as [r4048] upstream, thanks!

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
libdwarf/
2 lines

Diff 141148

View Options

contrib/elftoolchain/libdwarf/libdwarf_init.c

Loading...