Differential D46009

md5: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 16, 12:31 PM

	Unknown Object (File)
	Feb 15 2025, 4:53 AM

	Unknown Object (File)
	Jan 27 2025, 4:50 PM

	Unknown Object (File)
	Jan 27 2025, 12:19 AM

	Unknown Object (File)
	Jan 25 2025, 5:58 AM

	Unknown Object (File)
	Jan 24 2025, 1:58 AM

	Unknown Object (File)
	Jan 10 2025, 5:37 AM

	Unknown Object (File)
	Jan 9 2025, 9:11 PM

View All 83 Files

Subscribers

None

Details

Reviewers

imp
emaste
rlibby

Commits

rG7380c8ea849f: md5: Consistently use item count as the first argument to calloc
rG0c293d0425a7: md5: Consistently use item count as the first argument to calloc
rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc

Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM

jhb created this revision.

Harbormaster completed remote builds in B58691: Diff 141059.Jul 17 2024, 7:16 PM

jhb added a parent revision: D46008: lib80211: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM

jhb added a child revision: D46010: recoverdisk: Consistently use item count as the first argument to calloc.

rlibby accepted this revision.Jul 17 2024, 7:54 PM

This revision is now accepted and ready to land.Jul 17 2024, 7:54 PM

Closed by commit rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc.

jhb added a commit: rG0c293d0425a7: md5: Consistently use item count as the first argument to calloc.Nov 30 2024, 4:52 PM

jhb added a commit: rG7380c8ea849f: md5: Consistently use item count as the first argument to calloc.

Revision Contents
Changeset List

Path

Size

sbin/

md5/

2 lines

Diff 141150

sbin/md5/md5.c

	Show All 28 Lines
	FREEBSD_BOOT_LOADER opt_global.h			FREEBSD_BOOT_LOADER opt_global.h
	IXP4XX_FLASH_SIZE opt_global.h			IXP4XX_FLASH_SIZE opt_global.h
	KERNBASE opt_global.h			KERNBASE opt_global.h
	KERNVIRTADDR opt_global.h			KERNVIRTADDR opt_global.h
	LINUX_BOOT_ABI opt_global.h			LINUX_BOOT_ABI opt_global.h
	LOADERRAMADDR opt_global.h			LOADERRAMADDR opt_global.h
	PHYSADDR opt_global.h			PHYSADDR opt_global.h
	PLATFORM opt_global.h			PLATFORM opt_global.h
				PLATFORM_SMP opt_global.h
	SOCDEV_PA opt_global.h			SOCDEV_PA opt_global.h
	SOCDEV_VA opt_global.h			SOCDEV_VA opt_global.h
	PV_STATS opt_pmap.h			PV_STATS opt_pmap.h
	QEMU_WORKAROUNDS opt_global.h			QEMU_WORKAROUNDS opt_global.h
	SOC_ALLWINNER_A10 opt_global.h			SOC_ALLWINNER_A10 opt_global.h
	SOC_ALLWINNER_A20 opt_global.h			SOC_ALLWINNER_A20 opt_global.h
	SOC_ALLWINNER_A31 opt_global.h			SOC_ALLWINNER_A31 opt_global.h
	SOC_ALLWINNER_A31S opt_global.h			SOC_ALLWINNER_A31S opt_global.h
	Show All 31 Lines