elftoolchain: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.

Details

Reviewers

imp
emaste
rlibby

Commits

rGdb9ce08054dc: elftoolchain: Consistently use item count as the first argument to calloc
rG360c47b956d8: elftoolchain: Consistently use item count as the first argument to calloc
rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc

Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58689
Build 55577: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM

jhb created this revision.

jhb added a parent revision: D46006: libgeom: Consistently use item count as the first argument to calloc.

Harbormaster completed remote builds in B58689: Diff 141057.Jul 17 2024, 7:16 PM

jhb added a child revision: D46008: lib80211: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM

Will also ping @jkoshy

This revision is now accepted and ready to land.Jul 17 2024, 7:18 PM

Note that this was the only calloc instance in all of elftc that GCC warned about. All the others (even in this file) were already consistent with the number being first.

Hmm, I've been avoiding addressing warnings in contrib...

It's fine in elftoolchain - we are the primary consumer and either jkoshy or I can make the change upstream.

Closed by commit rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb73445a32f8a: elftoolchain: Consistently use item count as the first argument to calloc.

Folded in as [r4048] upstream, thanks!

jhb added a commit: rG360c47b956d8: elftoolchain: Consistently use item count as the first argument to calloc.Sat, Nov 30, 4:52 PM

jhb added a commit: rGdb9ce08054dc: elftoolchain: Consistently use item count as the first argument to calloc.

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

libdwarf/

libdwarf_init.c

2 lines

Diff 141057

View Options

contrib/elftoolchain/libdwarf/libdwarf_init.c

elftoolchain: Consistently use item count as the first argument to callocClosedPublicActions