Page MenuHomeFreeBSD
Differential D46004

libcxxrt: Add a stub implementation of __cxa_call_terminate
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.
Tags
None
Referenced Files
F142402071: D46004.id.diff
Mon, Jan 19, 3:56 PM
Unknown Object (File)
Sat, Jan 17, 4:49 AM
Unknown Object (File)
Tue, Dec 30, 2:25 PM
Unknown Object (File)
Mon, Dec 29, 1:57 AM
Unknown Object (File)
Sun, Dec 28, 7:14 PM
Unknown Object (File)
Sun, Dec 28, 8:18 AM
Unknown Object (File)
Dec 20 2025, 12:36 PM
Unknown Object (File)
Dec 20 2025, 1:31 AM
View All Files
Subscribers
None

Details

Reviewers
imp
emaste
rlibby
andrew
Commits
rG6b5a9d287d03: libcxxrt: Add a stub implementation of __cxa_call_terminate
rGa1269171d71f: libcxxrt: Add a stub implementation of __cxa_call_terminate
rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate
Summary

This function is called by GCC 14 if a destructor invoked during
exception unwinding throws an exception.

Obtained from: libcxxrt commit 391a3dcc1054e18c2f0dff4e14d6d79ac95399d7

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58958
Build 55845: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 17 2024, 7:16 PM
Herald added a reviewer: andrew. · View Herald TranscriptJul 17 2024, 7:16 PM
jhb requested review of this revision.Jul 17 2024, 7:16 PM
jhb added a parent revision: D46003: Merge commit cb7a03b41fff from llvm git (by Nikolas Klauser):.
Harbormaster completed remote builds in B58686: Diff 141054.Jul 17 2024, 7:16 PM
jhb added a child revision: D46005: libcasper: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM
jhb added a comment.Jul 17 2024, 7:25 PM

I am not at all confident that this implementation is correct, and I've opened an upstream issue at https://github.com/libcxxrt/libcxxrt/issues/35

jhb updated this revision to Diff 141866.Aug 6 2024, 8:28 PM

Fix whitespace

Harbormaster completed remote builds in B58958: Diff 141866.Aug 6 2024, 8:28 PM
jhb edited the summary of this revision. (Show Details)Aug 6 2024, 8:28 PM

This has now been merged upstream to libcxxrt at https://github.com/libcxxrt/libcxxrt/pull/36. This is the last change needed to permit building amd64 with GCC 14.

jhb added a comment.Aug 20 2024, 8:47 PM

Ping

emaste accepted this revision.Aug 20 2024, 8:49 PM
This revision is now accepted and ready to land.Aug 20 2024, 8:49 PM
Closed by commit rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate (authored by jhb). · Explain WhyAug 21 2024, 5:38 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG297a9e552b9a: libcxxrt: Add a stub implementation of __cxa_call_terminate.
emaste added a commit: rGa1269171d71f: libcxxrt: Add a stub implementation of __cxa_call_terminate.Oct 29 2024, 9:04 PM
jhb added a commit: rG6b5a9d287d03: libcxxrt: Add a stub implementation of __cxa_call_terminate.Nov 30 2024, 8:14 PM

Revision Contents
Changeset List

PathSize
contrib/
libcxxrt/
13 lines
lib/
libcxxrt/
4 lines
4 lines

Diff 141866

View Options

contrib/libcxxrt/exception.cc

Loading...
View Options

lib/libcxxrt/Version.map

Loading...
View Options

lib/libcxxrt/Version.map.arm

Loading...