bhyve: avoid a potential deadlock
ClosedPublic
Actions

Authored by khorben on May 29 2024, 3:49 PM.

Details

Reviewers

imp
corvink
markj

Group Reviewers

bhyve

Commits

rG1616f7d4b57b: bhyve: avoid a potential deadlock
rG1f3bfc60550c: bhyve: avoid a potential deadlock

Summary

This unlocks a mutex in an error path, that would otherwise remain locked and potentially cause a deadlock later on.

Reported by: Coverity Scan
CID: 1521334
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khorben created this revision.May 29 2024, 3:49 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMay 29 2024, 3:49 PM

Herald added subscribers: bcran, rgrimes. · View Herald Transcript

khorben requested review of this revision.May 29 2024, 3:49 PM

khorben edited the summary of this revision. (Show Details)May 29 2024, 3:52 PM

markj accepted this revision as: markj.May 29 2024, 8:39 PM

This revision is now accepted and ready to land.May 29 2024, 8:39 PM

corvink accepted this revision.Jun 3 2024, 5:57 AM

What's CID: 1521334?

In D45401#1053575, @corvink wrote:

What's CID: 1521334?

It's the identifier from Coverity for the vulnerability reported.

Closed by commit rG1f3bfc60550c: bhyve: avoid a potential deadlock (authored by khorben, committed by corvink). · Explain WhyAug 5 2024, 8:01 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG1f3bfc60550c: bhyve: avoid a potential deadlock.

corvink added a commit: rG1616f7d4b57b: bhyve: avoid a potential deadlock.Nov 12 2024, 7:56 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

tpm_intf_crb.c

4 lines

Diff 141820

View Options

usr.sbin/bhyve/tpm_intf_crb.c

bhyve: avoid a potential deadlockClosedPublicActions