Page MenuHomeFreeBSD
Differential D46035

cam/iosched: Pass in the disk when initializing
ClosedPublic
Actions

Authored by imp on Jul 18 2024, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 1:40 PM
Unknown Object (File)
Oct 1 2024, 4:42 PM
Unknown Object (File)
Oct 1 2024, 2:55 PM
Unknown Object (File)
Sep 30 2024, 7:04 PM
Unknown Object (File)
Sep 29 2024, 7:51 AM
Unknown Object (File)
Sep 28 2024, 11:02 AM
Unknown Object (File)
Sep 26 2024, 10:36 PM
Unknown Object (File)
Sep 26 2024, 4:45 PM
View All 39 Files
Subscribers
dab

Details

Reviewers
mav
jhb
Group Reviewers
cam
Commits
rG6f1dd6071a91: cam/iosched: Pass in the disk when initializing
Summary

The disk is nice to have at times, especially when you need the sector
size. At present, the only plans for this are related to logging.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58723
Build 55611: arc lint + arc unit

Event Timeline

imp created this revision.Jul 18 2024, 10:02 PM
Herald added a reviewer: cam. · View Herald TranscriptJul 18 2024, 10:02 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jul 18 2024, 10:02 PM
Harbormaster completed remote builds in B58718: Diff 141099.Jul 18 2024, 10:02 PM
imp added a parent revision: D46034: cam/iosched: Pass the transaction down we're collecting stats for.Jul 18 2024, 10:02 PM
imp added a child revision: D46036: cam/iosched: Log outlier latency events.
imp updated this revision to Diff 141107.Jul 19 2024, 4:22 AM

Misc updates with testing

Harbormaster completed remote builds in B58723: Diff 141107.Jul 19 2024, 4:22 AM
jhb accepted this revision.Jul 19 2024, 3:29 PM
jhb added inline comments.
sys/cam/cam_iosched.c
1161

Old bug: this would be more readable IMO with a local variable, that is:

{
     struct cam_iosched_softc *isc;

     isc = malloc(sizeof(*isc), ...);
     ...
     *iscp = isc;
     return 0;
}
This revision is now accepted and ready to land.Jul 19 2024, 3:29 PM
Closed by commit rG6f1dd6071a91: cam/iosched: Pass in the disk when initializing (authored by imp). · Explain WhyJul 20 2024, 2:59 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG6f1dd6071a91: cam/iosched: Pass in the disk when initializing.

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
19 lines
3 lines
5 lines
nvme/
17 lines
scsi/
16 lines

Diff 141107

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/cam_iosched.h

Loading...
View Options

sys/cam/cam_iosched.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...