Page MenuHomeFreeBSD

cam/iosched: Pass in the disk when initializing
ClosedPublic

Authored by imp on Jul 18 2024, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 1:40 PM
Unknown Object (File)
Oct 1 2024, 4:42 PM
Unknown Object (File)
Oct 1 2024, 2:55 PM
Unknown Object (File)
Sep 30 2024, 7:04 PM
Unknown Object (File)
Sep 29 2024, 7:51 AM
Unknown Object (File)
Sep 28 2024, 11:02 AM
Unknown Object (File)
Sep 26 2024, 10:36 PM
Unknown Object (File)
Sep 26 2024, 4:45 PM
Subscribers

Details

Summary

The disk is nice to have at times, especially when you need the sector
size. At present, the only plans for this are related to logging.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 18 2024, 10:02 PM

Misc updates with testing

jhb added inline comments.
sys/cam/cam_iosched.c
1161

Old bug: this would be more readable IMO with a local variable, that is:

{
     struct cam_iosched_softc *isc;

     isc = malloc(sizeof(*isc), ...);
     ...
     *iscp = isc;
     return 0;
}
This revision is now accepted and ready to land.Jul 19 2024, 3:29 PM
This revision was automatically updated to reflect the committed changes.