bsd.progs.mk: Create directories first
ClosedPublic
Actions

Authored by cperciva on Jul 8 2024, 4:37 PM.

Details

Reviewers

brooks
jrtc27
sjg

Commits

rGfe945fa9c91d: bsd.progs.mk: Create directories first
rG187d696a0aa0: bsd.progs.mk: Create directories first

Summary

Order installdirs before the $p.install targets; this is necessary
when a user of <bsd.progs.mk> also creates the directory into which
the binaries are installed.

In particular, without this patch running make installworld -jN can
break when installing tests since the /usr/tests/foo/bar directories
are created during installworld; this has been causing the stable/14
weekly snapshot builds to intermittently fail for months.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58572
Build 55460: arc lint + arc unit

Event Timeline

cperciva created this revision.Jul 8 2024, 4:37 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJul 8 2024, 4:37 PM

cperciva requested review of this revision.Jul 8 2024, 4:37 PM

Harbormaster completed remote builds in B58572: Diff 140701.Jul 8 2024, 4:37 PM

Ping?

This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2024, 2:47 PM

Closed by commit rG187d696a0aa0: bsd.progs.mk: Create directories first (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG187d696a0aa0: bsd.progs.mk: Create directories first.

cperciva added a commit: rGfe945fa9c91d: bsd.progs.mk: Create directories first.

sjg added inline comments.Jul 11 2024, 9:52 PM

share/mk/bsd.progs.mk
158	FWIW I tend to avoid putting things in `.for` loops if I can, also you need `:` you could put this after the `.endfor` `.ORDER: installdirs ${PROGS:@p@$p.install@}`