Paths

Table of Contentst

Differential D45776

sound: Make DSP_FIXUP_ERROR() regular code
ClosedPublic
Actions

Authored by christos on Jun 29 2024, 3:38 PM.

Tags

None

Referenced Files

	F172200540: D45776.id140359.diff
	Wed, Sep 16, 7:52 PM

	F172198958: D45776.diff
	Wed, Sep 16, 7:30 PM

	Unknown Object (File)
	Fri, Sep 11, 9:11 PM

	Unknown Object (File)
	Fri, Sep 11, 6:10 AM

	Unknown Object (File)
	Thu, Sep 10, 9:16 AM

	Unknown Object (File)
	Wed, Sep 9, 3:25 PM

	Unknown Object (File)
	Wed, Sep 9, 4:55 AM

	Unknown Object (File)
	Tue, Sep 8, 5:38 AM

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGd4b65f3f53ee: sound: Make DSP_FIXUP_ERROR() regular code
rGadc1713fb13f: sound: Make DSP_FIXUP_ERROR() regular code

Summary

No reason to have this as a macro. No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Jun 29 2024, 3:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2024, 3:38 PM

christos requested review of this revision.Jun 29 2024, 3:38 PM

Harbormaster completed remote builds in B58394: Diff 140359.Jun 29 2024, 3:38 PM

christos added a parent revision: D45775: sound: Simplify getchns().Jun 29 2024, 3:38 PM

markj accepted this revision.Jun 30 2024, 3:30 PM

This revision is now accepted and ready to land.Jun 30 2024, 3:30 PM

Expanding this inline LGTM. I wonder if it should be else if though (as a subsequent change)

In D45776#1044783, @emaste wrote:

Expanding this inline LGTM. I wonder if it should be else if though (as a subsequent change)

I agree with making it an else if. If the open flags are invalid then we don't need to check the second if at all. I think this change can be included in this patch though.

dev_submerge.ch accepted this revision.Jul 3 2024, 5:05 PM

Closed by commit rGadc1713fb13f: sound: Make DSP_FIXUP_ERROR() regular code (authored by christos). · Explain WhyJul 6 2024, 6:24 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGadc1713fb13f: sound: Make DSP_FIXUP_ERROR() regular code.

christos added a commit: rGd4b65f3f53ee: sound: Make DSP_FIXUP_ERROR() regular code.Jul 10 2024, 4:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

16 lines

Diff 140638

sys/dev/sound/pcm/dsp.c

Loading...