Page MenuHomeFreeBSD

ktls: Fix races that can lead to double initialization
ClosedPublic

Authored by markj on Jun 21 2024, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 4, 10:01 AM
Unknown Object (File)
Fri, Jul 25, 11:40 PM
Unknown Object (File)
Fri, Jul 25, 5:02 AM
Unknown Object (File)
Thu, Jul 24, 5:31 PM
Unknown Object (File)
Thu, Jul 24, 12:40 PM
Unknown Object (File)
Wed, Jul 23, 12:33 PM
Unknown Object (File)
Tue, Jul 22, 8:49 PM
Unknown Object (File)
Wed, Jul 16, 1:19 AM
Subscribers

Details

Summary

ktls_enable_rx() and ktls_enable_tx() have checks to return EALREADY if
the socket already has KTLS enabled. However, these are done without
any locks held and nothing blocks concurrent attempts to set the socket
option. I believe the worst outcome of the race is leaked memory.

Fix the problem by rechecking under the sockbuf lock. While here,
unify the locking protocol for sb_tls_info: require both the sockbuf and
socket I/O locks in order to enable KTLS. This means that either lock
is sufficient for checking whether KTLS is enabled in a given sockbuf,
which simplifies some refactoring further down the road.

Note that the SOLISTENING() check can go away because
SOCK_IO_RECV_LOCK() atomically locks the socket buffer and checks
whether the socket is a listening socket. This changes the errno value,
so update a test which checks it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58283
Build 55171: arc lint + arc unit