subr_rangeset: use pctrie_reclaim_callback in remove_all
ClosedPublic
Actions

Authored by dougm on Jun 13 2024, 4:57 PM.

Details

Reviewers

kib
rlibby

Commits

rGa7f67ebd8275: subr_rangeset: use pctrie_reclaim_cb in remove_all

Summary

Replace the lookup-and-remove loop in rangeset_remove_all with a call to RANGESET_PCTRIE_RECLAIM_CALLBACK, to avoid the repeated lookups.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 13 2024, 4:57 PM

dougm created this revision.

Logic looks good.

This does make me think, should we arrange to have name##_PCTRIE_RECLAIM_CALLBACK take a function pointer that is typed for the first argument? We would then need a cast to pctrie_cb_t for the calls to begin_cb/resume_cb, which I think both gcc and clang are okay with, but I am not actually sure what the standard says. That would help avoid mixing up the two void *s in the callback type and avoid the need for one of the casts in the callback.

This revision is now accepted and ready to land.Jun 13 2024, 5:39 PM

In D45584#1039980, @rlibby wrote:

This does make me think, should we arrange to have name##_PCTRIE_RECLAIM_CALLBACK take a function pointer that is typed for the first argument? We would then need a cast to pctrie_cb_t for the calls to begin_cb/resume_cb, which I think both gcc and clang are okay with, but I am not actually sure what the standard says. That would help avoid mixing up the two void *s in the callback type and avoid the need for one of the casts in the callback.

I'm not opposed, though I'm also not sure about the standard. But I think I'll commit these bits first, and consider that next.

Closed by commit rGa7f67ebd8275: subr_rangeset: use pctrie_reclaim_cb in remove_all (authored by dougm). · Explain WhyJun 13 2024, 6:53 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGa7f67ebd8275: subr_rangeset: use pctrie_reclaim_cb in remove_all.

Herald added subscribers: olce, imp. · View Herald TranscriptJun 13 2024, 6:53 PM