Page MenuHomeFreeBSD

subr_rangeset: use pctrie_reclaim_callback in remove_all
ClosedPublic

Authored by dougm on Jun 13 2024, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 4:56 PM
Unknown Object (File)
Sep 10 2025, 3:01 AM
Unknown Object (File)
Sep 4 2025, 8:28 AM
Unknown Object (File)
Jul 27 2025, 7:39 AM
Unknown Object (File)
Jul 10 2025, 6:57 AM
Unknown Object (File)
Jul 9 2025, 3:14 PM
Unknown Object (File)
Jun 27 2025, 6:58 PM
Unknown Object (File)
Jun 26 2025, 8:00 PM
Subscribers

Details

Summary

Replace the lookup-and-remove loop in rangeset_remove_all with a call to RANGESET_PCTRIE_RECLAIM_CALLBACK, to avoid the repeated lookups.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 13 2024, 4:57 PM
dougm created this revision.

Logic looks good.

This does make me think, should we arrange to have name##_PCTRIE_RECLAIM_CALLBACK take a function pointer that is typed for the first argument? We would then need a cast to pctrie_cb_t for the calls to begin_cb/resume_cb, which I think both gcc and clang are okay with, but I am not actually sure what the standard says. That would help avoid mixing up the two void *s in the callback type and avoid the need for one of the casts in the callback.

This revision is now accepted and ready to land.Jun 13 2024, 5:39 PM

This does make me think, should we arrange to have name##_PCTRIE_RECLAIM_CALLBACK take a function pointer that is typed for the first argument? We would then need a cast to pctrie_cb_t for the calls to begin_cb/resume_cb, which I think both gcc and clang are okay with, but I am not actually sure what the standard says. That would help avoid mixing up the two void *s in the callback type and avoid the need for one of the casts in the callback.

I'm not opposed, though I'm also not sure about the standard. But I think I'll commit these bits first, and consider that next.