Page MenuHomeFreeBSD
Differential D45303

ibcore: Mark write-only variables
ClosedPublic
Actions

Authored by andrew on May 22 2024, 2:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 6:32 PM
Unknown Object (File)
Feb 9 2025, 8:40 PM
Unknown Object (File)
Feb 4 2025, 3:59 PM
Unknown Object (File)
Feb 4 2025, 2:54 PM
Unknown Object (File)
Jan 28 2025, 5:29 AM
Unknown Object (File)
Jan 27 2025, 4:46 PM
Unknown Object (File)
Jan 23 2025, 11:47 PM
Unknown Object (File)
Jan 18 2025, 9:50 PM
View All 47 Files
Subscribers
imp

Details

Reviewers
brooks
imp
jhb
kib
Commits
rG4de39679dc35: ibcore: Mark write-only variables
rG77d05874de8e: ibcore: Mark write-only variables
rG19782e5bef34: ibcore: Mark write-only variables
Summary

Some LinuxKPI lock macros pass need a flags field passed in. This is
written to but never read from so gcc complains.

Fix this by marking the flags variables as unused to quieten the
compiler.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.May 22 2024, 2:35 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2024, 2:35 PM
andrew requested review of this revision.May 22 2024, 2:35 PM
Harbormaster completed remote builds in B57847: Diff 138925.May 22 2024, 2:35 PM
andrew added a parent revision: D45302: stats: Fix the build under gcc.May 22 2024, 2:36 PM
andrew added reviewers: brooks, imp, jhb, kib.Jun 3 2024, 3:50 PM
brooks accepted this revision.Jun 3 2024, 5:34 PM

I wonder if we want a local #define __writeonly __unused for documentation purposes.

This revision is now accepted and ready to land.Jun 3 2024, 5:34 PM
imp added a comment.Jun 3 2024, 5:50 PM
In D45303#1037067, @brooks wrote:

I wonder if we want a local #define __writeonly __unused for documentation purposes.

If we do, maybe that's best in sys/cdefs.h instead of here?

kib accepted this revision.Jun 3 2024, 5:56 PM

May be instead, the *lock_irq* macros might do something to fake the argument use?

andrew updated this revision to Diff 139720.Jun 11 2024, 11:16 AM

Rebase on D45561

This revision now requires review to proceed.Jun 11 2024, 11:16 AM
Harbormaster completed remote builds in B58139: Diff 139720.Jun 11 2024, 11:16 AM
andrew added a parent revision: D45561: cdefs: Add __writeonly to mark write only vars.Jun 11 2024, 11:16 AM
kib accepted this revision.Jun 11 2024, 2:33 PM
This revision is now accepted and ready to land.Jun 11 2024, 2:33 PM
Closed by commit rG19782e5bef34: ibcore: Mark write-only variables (authored by andrew). · Explain WhyJun 12 2024, 3:52 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG19782e5bef34: ibcore: Mark write-only variables.
andrew added a commit: rG77d05874de8e: ibcore: Mark write-only variables.Jul 15 2024, 12:40 PM
andrew added a commit: rG4de39679dc35: ibcore: Mark write-only variables.Jul 15 2024, 12:44 PM

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
16 lines
4 lines

Diff 139755

View Options

sys/ofed/drivers/infiniband/core/ib_cache.c

Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines
static void vtcon_tty_free(void *); static void vtcon_tty_free(void *);
static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *, static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *,
uint16_t *); uint16_t *);
static void vtcon_enable_interrupts(struct vtcon_softc *); static void vtcon_enable_interrupts(struct vtcon_softc *);
static void vtcon_disable_interrupts(struct vtcon_softc *); static void vtcon_disable_interrupts(struct vtcon_softc *);
#define vtcon_modern(_sc) (((_sc)->vtcon_features & VIRTIO_F_VERSION_1) != 0)
#define vtcon_htog16(_sc, _val) virtio_htog16(vtcon_modern(_sc), _val)
#define vtcon_htog32(_sc, _val) virtio_htog32(vtcon_modern(_sc), _val)
#define vtcon_htog64(_sc, _val) virtio_htog64(vtcon_modern(_sc), _val)
#define vtcon_gtoh16(_sc, _val) virtio_gtoh16(vtcon_modern(_sc), _val)
#define vtcon_gtoh32(_sc, _val) virtio_gtoh32(vtcon_modern(_sc), _val)
#define vtcon_gtoh64(_sc, _val) virtio_gtoh64(vtcon_modern(_sc), _val)
static int vtcon_pending_free; static int vtcon_pending_free;
static struct ttydevsw vtcon_tty_class = { static struct ttydevsw vtcon_tty_class = {
.tsw_flags = 0, .tsw_flags = 0,
.tsw_open = vtcon_tty_open, .tsw_open = vtcon_tty_open,
.tsw_close = vtcon_tty_close, .tsw_close = vtcon_tty_close,
.tsw_outwakeup = vtcon_tty_outwakeup, .tsw_outwakeup = vtcon_tty_outwakeup,
.tsw_free = vtcon_tty_free, .tsw_free = vtcon_tty_free,
▲ Show 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
{ {
device_t dev; device_t dev;
uint64_t features; uint64_t features;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
features = VTCON_FEATURES; features = VTCON_FEATURES;
sc->vtcon_features = virtio_negotiate_features(dev, features); sc->vtcon_features = virtio_negotiate_features(dev, features);
virtio_finalize_features(dev);
} }
static void static void
vtcon_setup_features(struct vtcon_softc *sc) vtcon_setup_features(struct vtcon_softc *sc)
{ {
device_t dev; device_t dev;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
▲ Show 20 Lines • Show All 400 Lines • ▼ Show 20 Linesvtcon_ctrl_port_name_event(struct vtcon_softc *sc, int id, const char *name,
VTCON_PORT_UNLOCK(port); VTCON_PORT_UNLOCK(port);
} }
static void static void
vtcon_ctrl_process_event(struct vtcon_softc *sc, vtcon_ctrl_process_event(struct vtcon_softc *sc,
struct virtio_console_control *control, void *data, size_t data_len) struct virtio_console_control *control, void *data, size_t data_len)
{ {
device_t dev; device_t dev;
int id; uint32_t id;
uint16_t event;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
id = control->id; id = vtcon_htog32(sc, control->id);
event = vtcon_htog16(sc, control->event);
if (id < 0 || id >= sc->vtcon_max_ports) { if (id >= sc->vtcon_max_ports) {
device_printf(dev, "%s: invalid port ID %d\n", __func__, id); device_printf(dev, "%s: event %d invalid port ID %d\n",
__func__, event, id);
return; return;
} }
switch (control->event) { switch (event) {
case VIRTIO_CONSOLE_PORT_ADD: case VIRTIO_CONSOLE_PORT_ADD:
vtcon_ctrl_port_add_event(sc, id); vtcon_ctrl_port_add_event(sc, id);
break; break;
case VIRTIO_CONSOLE_PORT_REMOVE: case VIRTIO_CONSOLE_PORT_REMOVE:
vtcon_ctrl_port_remove_event(sc, id); vtcon_ctrl_port_remove_event(sc, id);
break; break;
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid, vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid,
uint16_t event, uint16_t value) uint16_t event, uint16_t value)
{ {
struct virtio_console_control control; struct virtio_console_control control;
if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0) if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0)
return; return;
control.id = portid; control.id = vtcon_gtoh32(sc, portid);
control.event = event; control.event = vtcon_gtoh16(sc, event);
control.value = value; control.value = vtcon_gtoh16(sc, value);
vtcon_ctrl_poll(sc, &control); vtcon_ctrl_poll(sc, &control);
} }
static int static int
vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len) vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len)
{ {
struct sglist_seg segs[2]; struct sglist_seg segs[2];
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines
View Options

sys/ofed/drivers/infiniband/core/ib_cm.c

Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines
static void vtcon_tty_free(void *); static void vtcon_tty_free(void *);
static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *, static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *,
uint16_t *); uint16_t *);
static void vtcon_enable_interrupts(struct vtcon_softc *); static void vtcon_enable_interrupts(struct vtcon_softc *);
static void vtcon_disable_interrupts(struct vtcon_softc *); static void vtcon_disable_interrupts(struct vtcon_softc *);
#define vtcon_modern(_sc) (((_sc)->vtcon_features & VIRTIO_F_VERSION_1) != 0)
#define vtcon_htog16(_sc, _val) virtio_htog16(vtcon_modern(_sc), _val)
#define vtcon_htog32(_sc, _val) virtio_htog32(vtcon_modern(_sc), _val)
#define vtcon_htog64(_sc, _val) virtio_htog64(vtcon_modern(_sc), _val)
#define vtcon_gtoh16(_sc, _val) virtio_gtoh16(vtcon_modern(_sc), _val)
#define vtcon_gtoh32(_sc, _val) virtio_gtoh32(vtcon_modern(_sc), _val)
#define vtcon_gtoh64(_sc, _val) virtio_gtoh64(vtcon_modern(_sc), _val)
static int vtcon_pending_free; static int vtcon_pending_free;
static struct ttydevsw vtcon_tty_class = { static struct ttydevsw vtcon_tty_class = {
.tsw_flags = 0, .tsw_flags = 0,
.tsw_open = vtcon_tty_open, .tsw_open = vtcon_tty_open,
.tsw_close = vtcon_tty_close, .tsw_close = vtcon_tty_close,
.tsw_outwakeup = vtcon_tty_outwakeup, .tsw_outwakeup = vtcon_tty_outwakeup,
.tsw_free = vtcon_tty_free, .tsw_free = vtcon_tty_free,
▲ Show 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
{ {
device_t dev; device_t dev;
uint64_t features; uint64_t features;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
features = VTCON_FEATURES; features = VTCON_FEATURES;
sc->vtcon_features = virtio_negotiate_features(dev, features); sc->vtcon_features = virtio_negotiate_features(dev, features);
virtio_finalize_features(dev);
} }
static void static void
vtcon_setup_features(struct vtcon_softc *sc) vtcon_setup_features(struct vtcon_softc *sc)
{ {
device_t dev; device_t dev;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
▲ Show 20 Lines • Show All 400 Lines • ▼ Show 20 Linesvtcon_ctrl_port_name_event(struct vtcon_softc *sc, int id, const char *name,
VTCON_PORT_UNLOCK(port); VTCON_PORT_UNLOCK(port);
} }
static void static void
vtcon_ctrl_process_event(struct vtcon_softc *sc, vtcon_ctrl_process_event(struct vtcon_softc *sc,
struct virtio_console_control *control, void *data, size_t data_len) struct virtio_console_control *control, void *data, size_t data_len)
{ {
device_t dev; device_t dev;
int id; uint32_t id;
uint16_t event;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
id = control->id; id = vtcon_htog32(sc, control->id);
event = vtcon_htog16(sc, control->event);
if (id < 0 || id >= sc->vtcon_max_ports) { if (id >= sc->vtcon_max_ports) {
device_printf(dev, "%s: invalid port ID %d\n", __func__, id); device_printf(dev, "%s: event %d invalid port ID %d\n",
__func__, event, id);
return; return;
} }
switch (control->event) { switch (event) {
case VIRTIO_CONSOLE_PORT_ADD: case VIRTIO_CONSOLE_PORT_ADD:
vtcon_ctrl_port_add_event(sc, id); vtcon_ctrl_port_add_event(sc, id);
break; break;
case VIRTIO_CONSOLE_PORT_REMOVE: case VIRTIO_CONSOLE_PORT_REMOVE:
vtcon_ctrl_port_remove_event(sc, id); vtcon_ctrl_port_remove_event(sc, id);
break; break;
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid, vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid,
uint16_t event, uint16_t value) uint16_t event, uint16_t value)
{ {
struct virtio_console_control control; struct virtio_console_control control;
if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0) if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0)
return; return;
control.id = portid; control.id = vtcon_gtoh32(sc, portid);
control.event = event; control.event = vtcon_gtoh16(sc, event);
control.value = value; control.value = vtcon_gtoh16(sc, value);
vtcon_ctrl_poll(sc, &control); vtcon_ctrl_poll(sc, &control);
} }
static int static int
vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len) vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len)
{ {
struct sglist_seg segs[2]; struct sglist_seg segs[2];
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines