bhyve: Fix the build with gcc
ClosedPublic
Actions

Authored by andrew on Jun 10 2024, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 11, 2:12 PM

	Unknown Object (File)
	Tue, Aug 11, 2:12 PM

	Unknown Object (File)
	Tue, Aug 11, 2:12 PM

	Unknown Object (File)
	Sun, Aug 9, 1:09 AM

	Unknown Object (File)
	Wed, Aug 5, 2:53 AM

	Unknown Object (File)
	Tue, Aug 4, 8:26 AM

	Unknown Object (File)
	Tue, Aug 4, 5:46 AM

	Unknown Object (File)
	Mon, Aug 3, 1:53 AM

Subscribers

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG9a4813e1dc17: bhyve: Fix the build with gcc

Summary

gcc doesn't like const and static to not be at the start of a variable
declaration. Update the gdb_regset arrays to make it more obvious they
are arrays of struct gdb_reg and to fix the gcc build.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58130
Build 55018: arc lint + arc unit

Event Timeline

andrew created this revision.Jun 10 2024, 5:21 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJun 10 2024, 5:21 PM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jun 10 2024, 5:21 PM

Harbormaster completed remote builds in B58130: Diff 139694.Jun 10 2024, 5:21 PM

markj accepted this revision as: markj.Jun 10 2024, 5:26 PM

This revision is now accepted and ready to land.Jun 10 2024, 5:26 PM

corvink accepted this revision.Jun 11 2024, 6:09 AM

Closed by commit rG9a4813e1dc17: bhyve: Fix the build with gcc (authored by andrew). · Explain WhyJun 11 2024, 1:13 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG9a4813e1dc17: bhyve: Fix the build with gcc.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

gdb.c

6 lines

Diff 139694

View Options

bhyve: Fix the build with gccClosedPublicActions