Page MenuHomeFreeBSD
Differential D33804

Remove the arm FIQ support
ClosedPublic
Actions

Authored by andrew on Jan 10 2022, 2:17 PM.
Tags
None
Referenced Files
F154218666: D33804.id.diff
Mon, Apr 27, 5:11 AM
Unknown Object (File)
Sun, Apr 26, 4:22 PM
Unknown Object (File)
Sat, Apr 25, 10:08 AM
Unknown Object (File)
Tue, Apr 21, 10:05 AM
Unknown Object (File)
Tue, Apr 21, 10:03 AM
Unknown Object (File)
Tue, Apr 14, 12:29 AM
Unknown Object (File)
Mon, Apr 13, 6:11 PM
Unknown Object (File)
Mon, Apr 13, 4:18 AM
View All Files
Subscribers
imp
mmel

Details

Reviewers
mmel
Group Reviewers
ARM
Commits
rG6abad5b6062d: Remove the arm FIQ support
Summary

It isn't used, and only masks/unmasks FIQs on the local CPU so will be
broken on SMP.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58066
Build 54954: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 10 2022, 2:17 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2022, 2:17 PM
andrew requested review of this revision.Jan 10 2022, 2:17 PM
Harbormaster completed remote builds in B43802: Diff 101195.Jan 10 2022, 2:17 PM
andrew updated this revision to Diff 101198.Jan 10 2022, 2:43 PM

Remove more fiq bits

Harbormaster completed remote builds in B43803: Diff 101198.Jan 10 2022, 2:43 PM
mmel added a subscriber: mmel.Jan 10 2022, 2:49 PM
mmel added inline comments.
sys/arm/arm/exception.S
365–366

.fiqv should be also removed

365–366

and also this .space and _C_LABEL(page0_data) on the next line.
In addition, the arm_vector_init() function in machdep.c should be modified accordingly.

andrew updated this revision to Diff 139511.Jun 5 2024, 2:34 PM

Remove more FIQ support

Harbormaster completed remote builds in B58066: Diff 139511.Jun 5 2024, 2:34 PM
mmel accepted this revision.Jun 9 2024, 3:29 PM
This revision is now accepted and ready to land.Jun 9 2024, 3:29 PM
Closed by commit rG6abad5b6062d: Remove the arm FIQ support (authored by andrew). · Explain WhyJun 10 2024, 3:30 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG6abad5b6062d: Remove the arm FIQ support.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
2 lines
37 lines
2 lines
4 lines
2 lines
4 lines
2 lines
include/
2 lines
conf/
2 lines

Diff 139511

View Options

sys/arm/arm/autoconf.c

Loading...
View Options

sys/arm/arm/exception.S

Loading...
View Options

sys/arm/arm/fiq.c

Loading...
View Options

sys/arm/arm/fiq_subr.S

Loading...
View Options

sys/arm/arm/machdep.c

Loading...
View Options

sys/arm/arm/pmap-v6.c

Loading...
View Options

sys/arm/arm/syscall.c

Loading...
View Options

sys/arm/arm/trap-v6.c

Loading...
View Options

sys/arm/arm/undefined.c

Loading...
View Options

sys/arm/include/cpu.h

Loading...
View Options

sys/arm/include/fiq.h

Loading...
View Options

sys/conf/files.arm

Loading...