Page MenuHomeFreeBSD
Differential D45303

ibcore: Mark write-only variables
ClosedPublic
Actions

Authored by andrew on May 22 2024, 2:35 PM.
Tags
None
Referenced Files
F168067892: D45303.diff
Wed, Aug 26, 5:40 AM
Unknown Object (File)
Tue, Aug 25, 11:57 AM
Unknown Object (File)
Tue, Aug 25, 12:30 AM
Unknown Object (File)
Mon, Aug 24, 10:37 PM
Unknown Object (File)
Mon, Aug 24, 7:32 PM
Unknown Object (File)
Mon, Aug 24, 9:48 AM
Unknown Object (File)
Sun, Aug 23, 9:35 PM
Unknown Object (File)
Sat, Aug 22, 8:05 PM
View All Files
Subscribers
imp

Details

Reviewers
brooks
imp
jhb
kib
Commits
rG4de39679dc35: ibcore: Mark write-only variables
rG77d05874de8e: ibcore: Mark write-only variables
rG19782e5bef34: ibcore: Mark write-only variables
Summary

Some LinuxKPI lock macros pass need a flags field passed in. This is
written to but never read from so gcc complains.

Fix this by marking the flags variables as unused to quieten the
compiler.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57847
Build 54735: arc lint + arc unit

Event Timeline

andrew created this revision.May 22 2024, 2:35 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2024, 2:35 PM
andrew requested review of this revision.May 22 2024, 2:35 PM
Harbormaster completed remote builds in B57847: Diff 138925.May 22 2024, 2:35 PM
andrew added a parent revision: D45302: stats: Fix the build under gcc.May 22 2024, 2:36 PM
andrew added reviewers: brooks, imp, jhb, kib.Jun 3 2024, 3:50 PM
brooks accepted this revision.Jun 3 2024, 5:34 PM

I wonder if we want a local #define __writeonly __unused for documentation purposes.

This revision is now accepted and ready to land.Jun 3 2024, 5:34 PM
imp added a comment.Jun 3 2024, 5:50 PM
In D45303#1037067, @brooks wrote:

I wonder if we want a local #define __writeonly __unused for documentation purposes.

If we do, maybe that's best in sys/cdefs.h instead of here?

kib accepted this revision.Jun 3 2024, 5:56 PM

May be instead, the *lock_irq* macros might do something to fake the argument use?

andrew updated this revision to Diff 139720.Jun 11 2024, 11:16 AM

Rebase on D45561

This revision now requires review to proceed.Jun 11 2024, 11:16 AM
Harbormaster completed remote builds in B58139: Diff 139720.Jun 11 2024, 11:16 AM
andrew added a parent revision: D45561: cdefs: Add __writeonly to mark write only vars.Jun 11 2024, 11:16 AM
kib accepted this revision.Jun 11 2024, 2:33 PM
This revision is now accepted and ready to land.Jun 11 2024, 2:33 PM
Closed by commit rG19782e5bef34: ibcore: Mark write-only variables (authored by andrew). · Explain WhyJun 12 2024, 3:52 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG19782e5bef34: ibcore: Mark write-only variables.
andrew added a commit: rG77d05874de8e: ibcore: Mark write-only variables.Jul 15 2024, 12:40 PM
andrew added a commit: rG4de39679dc35: ibcore: Mark write-only variables.Jul 15 2024, 12:44 PM

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
16 lines
4 lines

Diff 138925

View Options

sys/ofed/drivers/infiniband/core/ib_cache.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cm.c

Loading...