sys/sys: Fix __builtin_is_aligned fallback
ClosedPublic
Actions

Authored by andrew on May 20 2024, 11:59 AM.

Details

Reviewers

brooks
imp
emaste
jhb

Group Reviewers

arm64

Commits

rGe63ac0eb580b: sys/sys: Fix __builtin_is_aligned fallback
rGf028010f4eac: sys/sys: Fix __builtin_is_aligned fallback
rG940155d24afb: sys/sys: Fix __builtin_is_aligned fallback

Summary

When the compiler doesn't provide __builtin_is_aligned we use
macro as a fallback. The macro was missing brackets around one
argument. This could lead to incorrect results when the argument is
more complex than a single stagement.

Fix this by adding the needed brackets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57774
Build 54662: arc lint + arc unit

Event Timeline

andrew requested review of this revision.May 20 2024, 11:59 AM

andrew created this revision.

andrew added a parent revision: D45259: csu: Find the main pointer through the GOT.

andrew added a child revision: D45261: arm64: Use the UL macro in TCR_EL1 defines.

Harbormaster completed remote builds in B57774: Diff 138761.May 20 2024, 12:01 PM

jhb accepted this revision.May 20 2024, 5:24 PM

This revision is now accepted and ready to land.May 20 2024, 5:24 PM

brooks accepted this revision.May 20 2024, 6:20 PM

imp accepted this revision.May 20 2024, 6:24 PM

Closed by commit rG940155d24afb: sys/sys: Fix __builtin_is_aligned fallback (authored by andrew). · Explain WhyMay 22 2024, 8:33 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG940155d24afb: sys/sys: Fix __builtin_is_aligned fallback.

andrew added a commit: rGf028010f4eac: sys/sys: Fix __builtin_is_aligned fallback.Jul 15 2024, 12:39 PM

andrew added a commit: rGe63ac0eb580b: sys/sys: Fix __builtin_is_aligned fallback.

Revision Contents
Changeset List

Path

Size

sys/

cdefs.h

2 lines

Diff 138761

View Options

sys/sys: Fix __builtin_is_aligned fallbackClosedPublicActions