Page MenuHomeFreeBSD
Differential D45098

adduser: Fix confusion between `uclass` and `_class`.
ClosedPublic
Actions

Authored by des on May 6 2024, 12:00 PM.
Tags
None
Referenced Files
F113955115: D45098.id138157.diff
Sun, Apr 6, 3:55 AM
F113923935: D45098.id138159.diff
Sat, Apr 5, 4:35 PM
Unknown Object (File)
Mon, Mar 24, 9:08 AM
Unknown Object (File)
Feb 22 2025, 8:44 PM
Unknown Object (File)
Jan 25 2025, 5:05 PM
Unknown Object (File)
Jan 20 2025, 2:50 PM
Unknown Object (File)
Jan 17 2025, 10:03 PM
Unknown Object (File)
Jan 8 2025, 9:02 AM
View All 48 Files
Subscribers
None

Details

Reviewers
• karels
imp
allanjude
Commits
rG01872b366578: adduser: Fix confusion between `uclass` and `_class`.
rG9f21d0ef9196: adduser: Fix confusion between `uclass` and `_class`.
rGe121845426c8: adduser: Fix confusion between `uclass` and `_class`.
rG46c4e86ebf18: adduser: Fix confusion between `uclass` and `_class`.
Summary

This caused adduser to produce an invalid pw(8) command line. Due to
bugs in pw(8), the command line was silently accepted and led to the
user being created, but locked out and with no home directory.

Fixes: 170d0882903e
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57595
Build 54483: arc lint + arc unit

Event Timeline

des requested review of this revision.May 6 2024, 12:00 PM
des created this revision.
Harbormaster completed remote builds in B57593: Diff 138157.May 6 2024, 12:00 PM
des added a parent revision: D45097: pw: Don't silently ignore unparsed command line arguments..May 6 2024, 12:00 PM
des updated this revision to Diff 138158.May 6 2024, 12:45 PM

move _another_user

Harbormaster completed remote builds in B57594: Diff 138158.May 6 2024, 12:45 PM
• karels added a comment.May 6 2024, 12:48 PM

I may not be the best reviewer for this change; I haven't used "local".

allanjude accepted this revision.May 6 2024, 1:11 PM
This revision is now accepted and ready to land.May 6 2024, 1:11 PM
• karels added a comment.May 6 2024, 1:21 PM

I applied this change (only) and ran the script; I got:

OK? (yes/no) [yes]:
adduser.fix: INFO: Successfully added (mike) to the user database.
local: Not in a function
Add another user? (yes/no) []:

des added a comment.May 6 2024, 1:22 PM
In D45098#1028400, @karels wrote:

I may not be the best reviewer for this change; I haven't used "local".

Perhaps, but you reported the bug and you can at least test the patch.

des updated this revision to Diff 138159.May 6 2024, 1:23 PM

not in a function

This revision now requires review to proceed.May 6 2024, 1:23 PM
Harbormaster completed remote builds in B57595: Diff 138159.May 6 2024, 1:23 PM
• karels added a comment.May 6 2024, 1:43 PM

This version works (adds the user correctly and defaults to not adding another user). Tested only on UFS; will test on ZFS in an hour or so.

• karels added a comment.May 6 2024, 2:22 PM

Works on ZFS too; dataset added and home directory set up correctly.

des added a comment.May 6 2024, 2:38 PM

Can you please approve it, then?

• karels accepted this revision.May 6 2024, 3:26 PM

Accepted, based mostly on Alan's previous approval.

This revision is now accepted and ready to land.May 6 2024, 3:26 PM
Closed by commit rG46c4e86ebf18: adduser: Fix confusion between `uclass` and `_class`. (authored by des). · Explain WhyMay 6 2024, 4:20 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG46c4e86ebf18: adduser: Fix confusion between `uclass` and `_class`..
des added a commit: rGe121845426c8: adduser: Fix confusion between `uclass` and `_class`..May 9 2024, 1:16 PM
des added a commit: rG9f21d0ef9196: adduser: Fix confusion between `uclass` and `_class`..
des added a commit: rG01872b366578: adduser: Fix confusion between `uclass` and `_class`..May 9 2024, 2:32 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
adduser/
6 lines

Diff 138159

View Options

usr.sbin/adduser/adduser.sh

Loading...