Page MenuHomeFreeBSD

john.grafton_runbox.com (John Grafton)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2021, 7:36 PM (83 w, 4 d)

Recent Activity

Tue, Nov 29

john.grafton_runbox.com added a comment to D36714: EFI wake time.

I was unable to test this patch. efi.h patch fails against CURRENT. D28620 abstracted the EFI public interface functions to support Xen VMs.

Tue, Nov 29, 7:31 PM
john.grafton_runbox.com added a reviewer for D37434: check if accounting is active before attempting to rotate accounting logs: Src Committers.
Tue, Nov 29, 11:58 AM

Mon, Nov 28

john.grafton_runbox.com added a reviewer for D37501: 'not function' for user display for top(1): imp.

@imp reviewed my code when I added a feature to top awhile back, let's see if he has time.

Mon, Nov 28, 4:30 PM

Fri, Nov 25

john.grafton_runbox.com added a comment to D37501: 'not function' for user display for top(1).

Neat feature! Tested and it appears to function correctly. I just noticed a simple grammar error in man page update.

Fri, Nov 25, 8:59 PM

Fri, Nov 18

john.grafton_runbox.com requested review of D37434: check if accounting is active before attempting to rotate accounting logs.
Fri, Nov 18, 4:12 PM

Oct 19 2022

john.grafton_runbox.com updated the diff for D36949: linprocfs(5): Add /proc/net/route.
  • dst and mask as stack variables
  • simpler flag calculation
Oct 19 2022, 10:10 PM
john.grafton_runbox.com added inline comments to D36949: linprocfs(5): Add /proc/net/route.
Oct 19 2022, 10:10 PM
john.grafton_runbox.com added a comment to D36950: disable sendmail with variables specified in rc.sendmail(8).

Honestly, I don't have an opinion on whether the documentation or code should be changed.

Oct 19 2022, 6:08 PM
john.grafton_runbox.com updated the diff for D36949: linprocfs(5): Add /proc/net/route.
  • updated from reviewer notes
Oct 19 2022, 5:33 PM
john.grafton_runbox.com added inline comments to D36949: linprocfs(5): Add /proc/net/route.
Oct 19 2022, 5:31 PM

Oct 18 2022

john.grafton_runbox.com added a comment to D36949: linprocfs(5): Add /proc/net/route.

Thanks again for the reviews. The rib_walk function is indeed much better than a kernel sysctl! Not sure if Linux outputs multipath routes in proc/net/route, I'll take a look at its source.

Oct 18 2022, 7:39 PM
john.grafton_runbox.com updated the diff for D36949: linprocfs(5): Add /proc/net/route.
  • support metric
Oct 18 2022, 7:29 PM
john.grafton_runbox.com updated the diff for D36949: linprocfs(5): Add /proc/net/route.

working version utilizing rib_walk

Oct 18 2022, 6:46 PM

Oct 17 2022

john.grafton_runbox.com added inline comments to D36949: linprocfs(5): Add /proc/net/route.
Oct 17 2022, 6:00 PM

Oct 13 2022

john.grafton_runbox.com added a comment to D36949: linprocfs(5): Add /proc/net/route.

Ideally, I'd like to only malloc only the amount of memory needed for the sysctl results. This works in user sysctl by passing a NULL to oldp but the kernel_sysctl function doesn't appear to work the same way.

Oct 13 2022, 5:02 PM
john.grafton_runbox.com updated the diff for D36949: linprocfs(5): Add /proc/net/route.

Updated source from dchagin comments

Oct 13 2022, 4:52 PM

Oct 12 2022

john.grafton_runbox.com added a reviewer for D36950: disable sendmail with variables specified in rc.sendmail(8): emaste.
Oct 12 2022, 3:34 PM
john.grafton_runbox.com requested review of D36950: disable sendmail with variables specified in rc.sendmail(8).
Oct 12 2022, 3:29 PM
john.grafton_runbox.com updated the test plan for D36949: linprocfs(5): Add /proc/net/route.
Oct 12 2022, 2:50 PM
john.grafton_runbox.com requested review of D36949: linprocfs(5): Add /proc/net/route.
Oct 12 2022, 2:43 PM