Page MenuHomeFreeBSD

nvmecontrol: Flesh out nvmecontrol format information
ClosedPublic

Authored by imp on Apr 25 2024, 5:24 PM.
Tags
None
Referenced Files
F105164259: D44958.diff
Fri, Dec 13, 1:27 AM
Unknown Object (File)
Thu, Nov 21, 11:01 AM
Unknown Object (File)
Mon, Nov 18, 6:02 PM
Unknown Object (File)
Mon, Nov 18, 11:01 AM
Unknown Object (File)
Mon, Nov 18, 3:47 AM
Unknown Object (File)
Sun, Nov 17, 11:54 PM
Unknown Object (File)
Sun, Nov 17, 10:11 AM
Unknown Object (File)
Nov 10 2024, 6:35 PM

Details

Summary

The format command takes a number of different parameters. Include a
brief summary of what the values mean, though since the driver's support
for metadata is at best weak, 0's are almost always used for values
other than -f format. Add example.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57378
Build 54266: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 25 2024, 5:24 PM

This looks good and helps explain (with examples) a common NVMe stumbling block.

sbin/nvmecontrol/nvmecontrol.8
451

I wonder if "index as reported ..." instead of "#, " would make it clear to the user they are using indices reported by the drive and not the format size.

This revision is now accepted and ready to land.Apr 25 2024, 9:34 PM

update per Chuck's idea of making it clear it's an index. Hopefully this makes
it clearer. Thanks Chuck!

This revision now requires review to proceed.Apr 25 2024, 11:16 PM
This revision is now accepted and ready to land.Apr 25 2024, 11:40 PM