Differential D44659

nvme: Eliminate intel_log_temp_stats_swapbytes
ClosedPublic
Actions

Authored by imp on Apr 6 2024, 6:57 PM.

Tags

None

Referenced Files

	F138844777: D44659.id137224.diff
	Fri, Dec 5, 7:53 AM

	Unknown Object (File)
	Tue, Dec 2, 5:04 PM

	Unknown Object (File)
	Sat, Nov 29, 7:15 PM

	Unknown Object (File)
	Fri, Nov 21, 11:03 AM

	Unknown Object (File)
	Tue, Nov 18, 11:18 PM

	Unknown Object (File)
	Sat, Nov 8, 2:02 AM

	Unknown Object (File)
	Nov 5 2025, 11:37 PM

	Unknown Object (File)
	Nov 5 2025, 7:04 AM

Subscribers

Details

Reviewers

jhb
chuck
mav

Commits

rG1dac1524786b: nvme: Eliminate intel_log_temp_stats_swapbytes
rG97b77de2d951: nvme: Eliminate intel_log_temp_stats_swapbytes

Summary

We can't post a AER for this page, so there's no need to be able to swap
it to host byte order. It's not one of the standard defined pages that
can post via AER, and the vendor's public docs for this temperature page
don't suggest it's possible to get over or under event changes. Since
nvmecontrol no longer needsd the swap routine, remove it since it's
now unused.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56943
Build 53831: arc lint + arc unit

Event Timeline

imp created this revision.Apr 6 2024, 6:57 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 6 2024, 6:57 PM

Harbormaster completed remote builds in B56943: Diff 136622.Apr 6 2024, 6:57 PM

imp requested review of this revision.Apr 6 2024, 6:57 PM

imp added a parent revision: D44658: nvmecontrol: Move intel temperature page printing to little endian orderinng.

chuck accepted this revision.Apr 8 2024, 3:16 PM

This revision is now accepted and ready to land.Apr 8 2024, 3:16 PM

imp added a child revision: D44680: nvmecontrol: Make the error log page work on native format.Apr 8 2024, 5:00 PM

imp removed a child revision: D44680: nvmecontrol: Make the error log page work on native format.

imp added a child revision: D44681: nvmecontrol: add newlines where needed for ns command printfs.Apr 8 2024, 5:06 PM

Closed by commit rG97b77de2d951: nvme: Eliminate intel_log_temp_stats_swapbytes (authored by imp). · Explain WhyApr 17 2024, 3:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG97b77de2d951: nvme: Eliminate intel_log_temp_stats_swapbytes.

jhb added a commit: rG1dac1524786b: nvme: Eliminate intel_log_temp_stats_swapbytes.Aug 27 2024, 1:08 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

17 lines

4 lines

Diff 136622

sys/dev/nvme/nvme.h

Loading...

sys/dev/nvme/nvme_ctrlr.c

Loading...